Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Currency in the metadata description #973

Draft
wants to merge 14 commits into
base: staging
Choose a base branch
from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Apr 18, 2024

High Level Overview of Change

This PR adds the use of the Currency element to the metadata processing, so that proper hex-converted currency codes are used and there are links to the currency pages.

Context of Change

It is difficult to read when currencies that have a code longer than 3 characters aren't displayed properly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Before:
image

After:
image

Test Plan

TODO

@pdp2121
Copy link
Collaborator

pdp2121 commented Jul 9, 2024

Is it for #925?

@mvadari mvadari linked an issue Jul 9, 2024 that may be closed by this pull request
@mvadari
Copy link
Collaborator Author

mvadari commented Jul 9, 2024

Is it for #925?

Yes, I forgot there was an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Currency type in tx metadata details
2 participants