Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fill price and remove price form summary and overview pages #988

Draft
wants to merge 7 commits into
base: staging
Choose a base branch
from

Conversation

shortthefomo
Copy link
Contributor

@shortthefomo shortthefomo commented May 26, 2024

High Level Overview of Change

Replace calculated price off offer created with the filled price.

Context of Change

The calculated price displayed on any instance of the component with the tfSell flag enabled. Makes the displayed data irrelevant and confusing.

Replacing the record with a filled price entry that shows the value the offer was filled at.

###OfferCreate's
Screenshot 2024-05-26 at 12 47 56 AM

Screenshot 2024-05-26 at 12 47 42 AM

###Payments
Screenshot 2024-05-27 at 9 28 05 AM
Screenshot 2024-05-27 at 9 27 57 AM

The issue is that the price value displayed and used ESP in the transaction lists eg. on an account or AMM page with all the offers that have crossed the non-execution calculated price displayed leads the user to assume that its the value at which the offer executed at.

This resolves that.

Additionally the tfSell flag is now rendered along with the components.

Type of Change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

TODO this still needs to be completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant