add fill price and remove price form summary and overview pages #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Replace calculated price off offer created with the filled price.
Context of Change
The calculated price displayed on any instance of the component with the tfSell flag enabled. Makes the displayed data irrelevant and confusing.
Replacing the record with a filled price entry that shows the value the offer was filled at.
###OfferCreate's
###Payments
The issue is that the price value displayed and used ESP in the transaction lists eg. on an account or AMM page with all the offers that have crossed the non-execution calculated price displayed leads the user to assume that its the value at which the offer executed at.
This resolves that.
Additionally the tfSell flag is now rendered along with the components.
Type of Change
TypeScript/Hooks Update
Before / After
Test Plan
TODO this still needs to be completed.