-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change UInt64-Base10 #99
Changes from all commits
cfb530b
842fd4d
7cb1ff2
8976460
e1ec80e
30a75c3
2ed3024
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file should be removed. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one too |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,8 +92,8 @@ An `mptoken` object has the following parameters: | |
|:-----------------------|:--------|:------------------------------------------| | ||
| `account` | string | The account address of the holder who owns the `MPToken`. | | ||
| `flags` | number | The flags assigned to the`MPToken` object. | | ||
| `mpt_amount` | string | Hex-encoded amount of the holder's balance. | | ||
| `locked_amount` | string | Hex-encoded amount of the locked balance. (Can be omitted if the value is 0.) | | ||
| `mpt_amount` | string | Base 10-encoded amount of the holder's balance. | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a blocker, but should we be saying base 10-encoded or decimal/hexadecimal? I don't have strong opinion either way, but I want to standardize the language we use in this instance. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we're going to say "hex" elsewhere, then I think it makes more sense to say "decimal" here. |
||
| `locked_amount` | string | Base 10-encoded amount of the locked balance. (Can be omitted if the value is 0.) | | ||
| `mptoken_index` | string | Key of the `MPToken` object. | | ||
|
||
#### Synthetic mpt_issuance_id field | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add
.DS_Store
files to the repo (they're some sort of Mac OS caching thing)