-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change UInt64-Base10 #99
Changes from 3 commits
cfb530b
842fd4d
7cb1ff2
8976460
e1ec80e
30a75c3
2ed3024
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file should be removed. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one too |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,8 +92,8 @@ An `mptoken` object has the following parameters: | |
|:-----------------------|:--------|:------------------------------------------| | ||
| `account` | string | The account address of the holder who owns the `MPToken`. | | ||
| `flags` | number | The flags assigned to the`MPToken` object. | | ||
| `mpt_amount` | string | Hex-encoded amount of the holder's balance. | | ||
| `locked_amount` | string | Hex-encoded amount of the locked balance. (Can be omitted if the value is 0.) | | ||
| `mpt_amount` | string | Base 10-encoded amount of the holder's balance. | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a blocker, but should we be saying base 10-encoded or decimal/hexadecimal? I don't have strong opinion either way, but I want to standardize the language we use in this instance. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we're going to say "hex" elsewhere, then I think it makes more sense to say "decimal" here. |
||
| `locked_amount` | string | Base 10-encoded amount of the locked balance. (Can be omitted if the value is 0.) | | ||
| `mptoken_index` | string | Key of the `MPToken` object. | | ||
|
||
#### Synthetic mpt_issuance_id field | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -52,9 +52,9 @@ The `MPTokenIssuanceID` is a 192-bit integer, concatenated in order: | |||||
| `Flags` | number | UInt32 | See [MPTokenIssuance Flags](#mptokenissuance-flags) | | ||||||
| `Issuer` | string | AccountID | The address of the account that controls both the issuance amounts and characteristics of a particular fungible token. | | ||||||
| `AssetScale` | number | UInt8 | An asset scale is the difference, in orders of magnitude, between a standard unit and a corresponding fractional unit. More formally, the asset scale is a non-negative integer (0, 1, 2, …) such that one standard unit equals 10^(-scale) of a corresponding fractional unit. If the fractional unit equals the standard unit, then the asset scale is 0. | | ||||||
| `MaximumAmount` | string | UInt64 | This value is an unsigned number that specifies the maximum number of MPTs that can be distributed to non-issuing accounts (i.e., minted). For issuances that do not have a maximum limit, this value should be set to 0xFFFFFFFFFFFFFFFF. | | ||||||
| `OutstandingAmount` | string | UInt64 | Specifies the sum of all token amounts that have been minted to all token holders. This value can be stored on ledger as a default type so that when its value is 0 it takes up less space on ledger. This value is increased whenever an issuer pays MPTs to a non-issuer account, and decreased whenever a non-issuer pays MPTs into the issuing account. | | ||||||
| `LockedAmount` | string | UInt64 | A positive amount of tokens that are currently held in a token holder's account, but are unavailable to be used by the token holder. Locked tokens might, for example, represent value currently being held in escrow, or value that is otherwise inaccessible to the token holder. This value is stored as a default value such that its initial value is 0, in order to save space on the ledger for an empty MPT holding. | | ||||||
| `MaximumAmount` | string | Base10 | This value is an unsigned number that specifies the maximum number of MPTs that can be distributed to non-issuing accounts (i.e., minted). For issuances that do not have a maximum limit, this value should be set to 18,446,744,073,709,551,615. | | ||||||
DennisDawson marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| `OutstandingAmount` | string | Base10 | Specifies the sum of all token amounts that have been minted to all token holders. This value can be stored on ledger as a default type so that when its value is 0 it takes up less space on ledger. This value is increased whenever an issuer pays MPTs to a non-issuer account, and decreased whenever a non-issuer pays MPTs into the issuing account. | | ||||||
DennisDawson marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| `LockedAmount` | string | Base10 | A positive amount of tokens that are currently held in a token holder's account, but are unavailable to be used by the token holder. Locked tokens might, for example, represent value currently being held in escrow, or value that is otherwise inaccessible to the token holder. This value is stored as a default value such that its initial value is 0, in order to save space on the ledger for an empty MPT holding. | | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
should also say that its base 10 in the description |
||||||
| `TransferFee` | number | UInt16 | This value specifies the fee, in tenths of a basis point, charged by the issuer for secondary sales of the token, if such sales are allowed at all. Valid values for this field are between 0 and 50,000 inclusive. A value of 1 is equivalent to 1/10 of a basis point or 0.001%, allowing transfer rates between 0% and 50%. A `TransferFee` of 50,000 corresponds to 50%. The default value for this field is 0. Any decimals in the transfer fee are rounded down. The fee can be rounded down to zero if the payment is small. Issuers should make sure that their MPT's `AssetScale` is large enough. | | ||||||
| `MPTokenMetadata` | string | Blob | Arbitrary metadata about this issuance, in hex format. The limit for this field is 1024 bytes. | | ||||||
| `PreviousTxnID` | string | Hash256 | Transaction ID of the transaction that most recently modified this object. | | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add
.DS_Store
files to the repo (they're some sort of Mac OS caching thing)