-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes old rippled integration #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legleux
commented
Jan 30, 2024
legleux
force-pushed
the
rm-nih
branch
2 times, most recently
from
February 6, 2024 19:11
0b735fa
to
07a4874
Compare
legleux
force-pushed
the
rm-nih
branch
3 times, most recently
from
February 13, 2024 19:07
06c89d1
to
75c520c
Compare
oleks-rip
previously approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oleks-rip
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Conan xrpl package contains all the components necessary to build xbwd now.
The |
Latest version is good |
oleks-rip
approved these changes
Apr 12, 2024
oleks-rip
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Remove old rippled integration The Conan xrpl package contains all the components necessary to build xbwd now. * Build packages with libxrpl * include xxhash * xbwd does not use xxhash; xxhash dep fixed in rippled-2.2.0-b2
oleks-rip
pushed a commit
that referenced
this pull request
May 3, 2024
* Remove old rippled integration The Conan xrpl package contains all the components necessary to build xbwd now. * Build packages with libxrpl * include xxhash * xbwd does not use xxhash; xxhash dep fixed in rippled-2.2.0-b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can not be merged until XRPLF/rippled#4885 has been integrated and the xrpl Conan package contains those headers.