Skip to content

Commit

Permalink
Merge pull request #48 from yeongjoshua/service-group-order
Browse files Browse the repository at this point in the history
Update service group subsection order and notification service id subscribe typo
  • Loading branch information
lftan authored Sep 6, 2024
2 parents 0a5b8e2 + dec4c0a commit 069ab75
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 40 deletions.
4 changes: 2 additions & 2 deletions src/message-protocol.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ events may also have additional data associated with them. Any action required
on behalf of an event depends on the application processor.
<<img-notification-format>> shows the notification message format.

Each service group has one service with a fixed `SERVICE_ID=0x00` to subscribe
Each service group has one service with a fixed `SERVICE_ID=0x01` to subscribe
to events. By default the event notification is disabled for each service
group and the application processor must subscribe to the supported events in
each service group to receive notification messages. Notification messages are
Expand Down Expand Up @@ -349,5 +349,5 @@ violates the extension specification or the extension version mismatch.
| Input/Output error.

| | -14 to -127 | _Reserved_
| | > -127 | _Vendor specific_
| | < -127 | _Vendor specific_
|===
24 changes: 12 additions & 12 deletions src/srvgrp-base.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,18 @@ The below table lists the services in this group:
| NORMAL_REQUEST
|===

==== RPMI Implementation IDs
[#table_base_rpmi_impl_id]
.RPMI Implementation IDs
[cols="2, 3a", width=100%, align="center", options="header"]
|===
| Implementation ID
| Name

|
|
|===

[#base-notifications]
==== Notifications
This service is used by the platform microcontroller to send the asynchronous
Expand Down Expand Up @@ -534,15 +546,3 @@ service to discover this capability and then use this service.
!===
- Other errors <<table_error_codes>>
|===

==== RPMI Implementation IDs
[#table_base_rpmi_impl_id]
.RPMI Implementation IDs
[cols="2, 3a", width=100%, align="center", options="header"]
|===
| Implementation ID
| Name

|
|
|===
52 changes: 26 additions & 26 deletions src/srvgrp-ras-agent.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,32 @@ Below table lists the services in this group:
| NORMAL_REQUEST
|===

==== Error Source Descriptor Format
===== ACPI Systems
For systems that support ACPI/APEI, the format of the error source descriptor
is as defined in ACPI specification v6.4 or above, (GHESv2) cite:[ACPI].
If the value of `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]` is `0`, it indicates that the
error source descriptor format is GHESv2.

The RAS agent populates the error source descriptor fields according to the
error source specified by `RAS_ERR_SRC_ID`.

NOTE: The error source descriptor has an `error_status_structure` field which
is a generic address structure (`GAS`) as defined in ACPI v6.4 (GHESv2)
cite:[ACPI]. This field specifies the location of a register that contains the
physical address of a block of memory that holds the error status data for the
specified error source. This block of memory is referred to as
`error_status_block`. The allocation of `error_status_block` is platform
dependent and is done by the RAS agent. The physical address of
`error_status_block` is stored in the `error_status_structure` field of the
error source descriptor being returned.

===== Non-ACPI Systems
RAS is not standardized for non-ACPI systems. Such systems may define custom
format for an error source descriptor. The type of custom error source
descriptor format can be read from `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]`. The
values from 1 to 15 are reserved for custom format types.

[#ras-notifications]
==== Notifications
This service group does not support any event for notification.
Expand Down Expand Up @@ -300,29 +326,3 @@ implementation specific.
| uint8
| Full or partial descriptor N is equal to the `RETURNED` bytes in this request.
|===

==== Error Source Descriptor Format
===== ACPI Systems
For systems that support ACPI/APEI, the format of the error source descriptor
is as defined in ACPI specification v6.4 or above, (GHESv2) cite:[ACPI].
If the value of `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]` is `0`, it indicates that the
error source descriptor format is GHESv2.

The RAS agent populates the error source descriptor fields according to the
error source specified by `RAS_ERR_SRC_ID`.

NOTE: The error source descriptor has an `error_status_structure` field which
is a generic address structure (`GAS`) as defined in ACPI v6.4 (GHESv2)
cite:[ACPI]. This field specifies the location of a register that contains the
physical address of a block of memory that holds the error status data for the
specified error source. This block of memory is referred to as
`error_status_block`. The allocation of `error_status_block` is platform
dependent and is done by the RAS agent. The physical address of
`error_status_block` is stored in the `error_status_structure` field of the
error source descriptor being returned.

===== Non-ACPI Systems
RAS is not standardized for non-ACPI systems. Such systems may define custom
format for an error source descriptor. The type of custom error source
descriptor format can be read from `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]`. The
values from 1 to 15 are reserved for custom format types.

0 comments on commit 069ab75

Please sign in to comment.