Update the error codes and move the shmem firmware section #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Pathak <[email protected]>
Signed-off-by: Rahul Pathak <[email protected]>
lftan
reviewed
Sep 4, 2024
|
|
||
| [#table_error_codes] | ||
| .Return Status Codes | ||
| .Return Error Codes |
There was a problem hiding this comment.
if we change this, all these below need to be changed as well.
There was a problem hiding this comment.
Yes, i was thinking to raise separate PRs for those, since we already need to update the error code names in all tables in each service
There was a problem hiding this comment.
You can update the CLOCK to RAS service groups, i will update rest
There was a problem hiding this comment.
okay, i will update CLOCK and RAS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.