Update CPPC service group #46
Conversation
src/srvgrp-cppc.adoc
Outdated
| the power/performance management software running on the application processor | ||
| and the platform to coordinate and manage the group level performance changes. | ||
|
|
||
| ==== CPPC Fast Channel |
There was a problem hiding this comment.
In Performance channel, it uses "Fast-Channel" in title, or use "Fast-channel" in the description as a special term.
So, we need to standardize this.
There was a problem hiding this comment.
Lets use Fast-channel or fast-channel a needed. Not the Fast-Channel
src/srvgrp-cppc.adoc
Outdated
| This service group defines the services to control application processor | ||
| performance by managing a set of registers per application processor | ||
| that are used for performance management and control. The ACPI CPPC | ||
| (Collaborative processor performance control) is an abstract and flexible |
There was a problem hiding this comment.
Collaborative Processor Performance Control
src/srvgrp-cppc.adoc
Outdated
| microcontroller to control the performance. | ||
|
|
||
| The CPPC extension defined in the RISC-V SBI specification cite:[SBI] defines | ||
| the register ids for the standard CPPC registers, together with additional |
src/srvgrp-cppc.adoc
Outdated
|
|
||
| The CPPC extension defined in the RISC-V SBI specification cite:[SBI] defines | ||
| the register ids for the standard CPPC registers, together with additional | ||
| registers also that are also by application processor. |
There was a problem hiding this comment.
This "also that are also by application processor" sentence sounds like a grammar problem.
src/srvgrp-cppc.adoc
Outdated
|
|
||
| For extra debugging, Hart can send a GET_CPPC_PERF_POKE message to exclusively request PuC to process the pending CPPC requests, if any. | ||
| | `CPPC2`(Autonomous) Mode |
There was a problem hiding this comment.
suggest adding a space before '(', same for the rest of this chapter.
src/srvgrp-cppc.adoc
Outdated
|
|
||
| PROBE_CPPC_REG service can be used to check if a particular CPPC register is implemented. The service READ_CPPC_REG can be used to read all implemented CPPC register values and WRITE_CPPC_REG can be used to write the registers. | ||
| ! 0x0 | ||
| ! Desired Performance Level |
src/srvgrp-cppc.adoc
Outdated
| The offset can be added into the `base-address` of the shared memory region to | ||
| form the address of a application processor fast channel. | ||
|
|
||
| ===== Fast Channel Doorbell |
There was a problem hiding this comment.
Do we need doorbell for fast channel?
Fast channel in the Performance service group doesn't support doorbell. Firmware can update data to the shared memory when has new update. Then AP can read the registers from shared memory anytime (read the last updated value).
Not sure if CPPC use case can use the same method?
There was a problem hiding this comment.
A interrupt mechanism with a transport completes the design even if not implemented.
I can see Performance service group has doorbell support that is also per domain
src/srvgrp-cppc.adoc
Outdated
| | 0x05 | CPPC_GET_FAST_CHANNEL_ATTRIBUTES | NORMAL_REQUEST | ||
| | 0x06 | CPPC_POKE_FAST_CHANNEL | NORMAL_REQUEST | ||
| | 0x07 | CPPC_GET_HART_LIST | NORMAL_REQUEST | ||
| | Service ID |
There was a problem hiding this comment.
Should move this Services table to before CPPC fast channel sub-chapter. It is part of CPPC fast channel sub-chapter now.
Some other service groups also have similar issue. I will update them.
src/srvgrp-cppc.adoc
Outdated
| all the application processors. If a doorbell is available then it must be | ||
| supported through a read-modify-write sequence to a memory-mapped register. | ||
| The doorbell details and attributes can be discovered by the application processor | ||
| through the defined service in this service group. | ||
|
|
||
| Below table lists the services in this group: |
There was a problem hiding this comment.
change to "this service group"
There was a problem hiding this comment.
This is better:
"The following table lists the services in the CPPC service group:"
src/srvgrp-cppc.adoc
Outdated
| ! Description | ||
|
|
||
| ! RPMI_SUCCESS | ||
| ! Notifications are subscribed successfully. |
There was a problem hiding this comment.
This service subscribes to a single EVENT_ID, so it should be a single notification.
So, change to "Notification is subscribed successfully."
I already changed this in CLOCK to RAS service groups, other service groups need to update.
There was a problem hiding this comment.
Yes, it has to be "Event is subscribed successfully." since subscription is happening for each event
src/srvgrp-cppc.adoc
Outdated
| ! `EVENT_ID` is invalid. | ||
|
|
||
| ! RPMI_ERR_NOT_SUPPORTED | ||
| ! Notifications not supported. |
There was a problem hiding this comment.
Same here, change to "Notification is not supported."
src/srvgrp-cppc.adoc
Outdated
| This service is used to probe a CPPC register implementation status for a | ||
| application processor. If the CPPC register `reg_id` is implemented then | ||
| the length in bits is returned in `REG_LENGTH` field. If the register is not | ||
| supported or invalid then the `REG_LENGTH` will be `0` |
src/srvgrp-cppc.adoc
Outdated
| | 1 | ||
| | REG_LENGTH | ||
| | uint32 | ||
| | Register length(bits) |
src/srvgrp-cppc.adoc
Outdated
| | DATA_HIGH | ||
| | uint32 | ||
| | Upper `32 bits` of data. This will be `0` if the register is of `32-bit` | ||
| length |
src/srvgrp-cppc.adoc
Outdated
| | 3 | ||
| | DATA_HIGH | ||
| | uint32 | ||
| | Upper `32 bits` of data. This is ignored is the register is of `32-bit` length. |
src/srvgrp-cppc.adoc
Outdated
| | 2 | ||
| | REGION_ADDR_LOW | ||
| | uint32 | ||
| | Lower `32-bit` of the fast channels shared memory region physical address. |
There was a problem hiding this comment.
Change to 32 bit (no "-"), consistent with others. Same for the rest below.
src/srvgrp-cppc.adoc
Outdated
| | 1 | ||
| | OFFSET_LOW | ||
| | uint32 | ||
| | Lower `32-bit` of a fast channel offset. |
There was a problem hiding this comment.
change to 32 bit, same for upper offset below.
src/srvgrp-cppc.adoc
Outdated
| | 0 | ||
| | STATUS | ||
| | int32 | ||
| | Return Status Code |
src/srvgrp-cppc.adoc
Outdated
| | 0 | ||
| | STATUS | ||
| | int32 | ||
| | Return Status Code |
src/srvgrp-cppc.adoc
Outdated
| | 0 | ||
| | START_INDEX | ||
| | uint32 | ||
| | Starting index of Hart ID |
There was a problem hiding this comment.
Choose to use "Hart ID" or "hart ID" for consistency.
The description below some uses "hart ID". Check the rest of chapter/document.
Signed-off-by: Rahul Pathak <[email protected]>
pathakraul
force-pushed
the
rpathak_cppc
branch
from
eac68b2
to
51e56e8
Compare
| | 1 | ||
| | DATA_LOW | ||
| | uint32 | ||
| | Lower `32-bit` of the data. |
There was a problem hiding this comment.
32 bit
Other service groups use "32 bit", no dash.
There was a problem hiding this comment.
I dont think so , I have been using this only places have dash
|
|
||
| [#table_cppc_pokefastchan_request_data] | ||
| 0b00: `8-bit` |
No description provided.