Spec update #55
Merged
Spec update #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lftan
commented
Sep 7, 2024
lftan
commented
- rearrange bit fields
- Fine-tune some descriptions
- Add reference link for hart state and suspend type.
added 2 commits
September 7, 2024 17:30
- Use the bit field at lower bits. - Update some description Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
pathakraul
reviewed
Sep 7, 2024
src/srvgrp-clock.adoc
Outdated
| | 2 | ||
| | NUM_RATES | ||
| | uint32 | ||
| | Number of clock rates depending on CLOCK_FORMAT. | ||
| | Number of clock rates depending on `CLOCK_FORMAT`. |
There was a problem hiding this comment.
This part is redundant "depending on CLOCK_FORMAT" . We have already established that each clock rate has a format in "Clock Rate Format" section
pathakraul
reviewed
Sep 7, 2024
src/srvgrp-device-power.adoc
Outdated
| | RESERVED | ||
| | _Reserved_ and must be `0`. | ||
|
|
||
| | [16] | ||
| | CONTEX |
pathakraul
reviewed
Sep 7, 2024
src/srvgrp-performance.adoc
Outdated
| @@ -367,7 +367,9 @@ level. | |||
| ! Bits | |||
| ! Description | |||
|
|
|||
| ! [31] | |||
| ! [31:11] ! _Reserved_ | |||
There was a problem hiding this comment.
Reserved and must be 0
added 4 commits
September 7, 2024 18:35
Signed-off-by: Ley Foon Tan <[email protected]>
- Add Hart State and suspend type reference link. - Combined Hart ID and Suspend types entry to one row. Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.