Define request forward service group #63
Conversation
avpatel
force-pushed
the
reqfwd_svcgrp_v1
branch
from
021ea8c
to
ad0e465
Compare
src/srvgrp-request-forward.adoc
Outdated
|
|
||
| [#reqfwd-notifications] | ||
| ==== Notifications | ||
| This service group does not support any event for notification. |
There was a problem hiding this comment.
There is Event support in this service group.
There was a problem hiding this comment.
Copy-paste error. I will update.
| | Description | ||
|
|
||
| | 0 | ||
| | RESPONSE_DATA[N] |
There was a problem hiding this comment.
Do we need a word for length (N) of RESPONSE_DATA?
There was a problem hiding this comment.
The N can be inferred from DATALEN in RPMI message header.
avpatel
force-pushed
the
reqfwd_svcgrp_v1
branch
2 times, most recently
from
1959d27
to
a973d0a
Compare
|
@avpatel do you want to include the following changes in this PR? Improve the RPMI REQUEST_FORWARD service group as follows:
|
Certain use-cases require forwarding RPMI messages from one RPMI client to another so let's define request forward service group for this purpose. Signed-off-by: Anup Patel <[email protected]>
avpatel
force-pushed
the
reqfwd_svcgrp_v1
branch
from
a973d0a
to
4ae22cd
Compare
Done |
|
Looks good to me |
|
@lftan @pathakraul Can you please merge this PR? I will create a separate PR for updating the MM service group. |
| | An array of `N` bytes representing the first `N` bytes of the current forwarded | ||
| RPMI request message. The value `N` is specified by the `EVENT_DATALEN` field of | ||
| the RPMI notification event as shown in <<table_notification_message_format>>. |
There was a problem hiding this comment.
Don't we need a word in the event data for either the total or remaining message length, so the caller knows if it needs to call REQFWD_RETRIEVE_CURRENT_MESSAGE at all?
There was a problem hiding this comment.
The event data has the first N bytes of the forwarded RPMI request message so it will include the forwarded RPMI header which can be used to compute the total message length (i.e. datalen in RPMI header + 8).
If event data size is less than 8 bytes then event data is of no use since it has partial RPMI header and we have to use REQFWD_RETRIEVE_CURRENT_MESSAGE service to get the forwarded RPMI request message.
There was a problem hiding this comment.
Ah, that makes sense, since we are limiting the payload to RPMI. Thanks.
Certain use-cases require forwarding RPMI messages from one RPMI client to another so let's define request forward service group for this purpose.