CPPC Service group improvements #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CPPC_GET_FAST_CHANNEL_REGION service request data does not need Hart ID parameter since this service returns complete region meant for all the harts fast channel entries Signed-off-by: Rahul Pathak <[email protected]>
Signed-off-by: Rahul Pathak <[email protected]>
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
|
|
||
| If the fast-channels are implemented, the application processor will either write | ||
| ===== Performance Request fast-channel. |
There was a problem hiding this comment.
"Fast-channel", and remove full stop for text header.
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
| @@ -122,33 +135,58 @@ Otherwise the application processor can call the service `CPPC_WRITE_REG` for th | |||
| ! 0x4 | |||
| ! Maximum performance level | |||
| !=== | |||
| |=== | |||
|
|
|||
| ===== Performance Feedback fast-channel. | |||
There was a problem hiding this comment.
"Fast-channel", and remove full stop for text header.
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
| `MinimumPerformanceRegister` and `MaximumPerformanceRegister`. | ||
|
|
||
| The layout of this fast-channel which depends on the CPPC mode, either normal or | ||
| autonomous mode is discoverable through a defined service. |
There was a problem hiding this comment.
Maybe can change "defined service" to a service name is better.
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
|
|
||
| [#table_cppc_fastchan] | ||
| .CPPC Fast-channel Layout | ||
| The size of this fast-channel type is of 8-byte. |
There was a problem hiding this comment.
The size of this fast-channel type is 8 bytes.
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
|
|
||
| The size of this fast-channel type is of 8-byte. |
There was a problem hiding this comment.
The size of this fast-channel type is 8 bytes.
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
| of `4-byte` each. A fast-channel must be naturally aligned to the size of the | ||
| fast-channel. | ||
| | 0x0 | ||
| | Current frequency Low 32-bit (Hz) |
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
| The offset can be added into the `base-address` of the shared memory region to | ||
| form the address of a application processor fast-channel. | ||
| | 0x4 | ||
| | Current frequency High 32-bit (Hz) |
lftan
reviewed
Oct 3, 2024
| to 8-byte. The offset of both fast-channel types in the shared memory region can | ||
| be discovered through service `CPPC_GET_FAST_CHANNEL_OFFSET`. The offsets | ||
| discovered can be added into the `base-address` of the shared memory region to | ||
| form the address of Performance Request fast-channel and Performance Feedback |
There was a problem hiding this comment.
"Performance Request Fast-channel"
lftan
reviewed
Oct 3, 2024
| be discovered through service `CPPC_GET_FAST_CHANNEL_OFFSET`. The offsets | ||
| discovered can be added into the `base-address` of the shared memory region to | ||
| form the address of Performance Request fast-channel and Performance Feedback | ||
| fast-channel for an application processor. |
There was a problem hiding this comment.
"Performance Feedback Fast-channel"
lftan
reviewed
Oct 3, 2024
src/srvgrp-cppc.adoc
Outdated
| between all the application processors. If a doorbell is available then it must | ||
| be supported through a read-modify-write sequence to a memory-mapped register. | ||
| The doorbell details and attributes can be discovered by the application | ||
| processor through the defined service in this service group. |
There was a problem hiding this comment.
can change "defined service" to the service name
lftan
reviewed
Oct 3, 2024
| | uint32 | ||
| | Lower 32-bit of a fast-channel offset. | ||
| | Lower 32-bit of a Performance Request fast-channel offset. |
There was a problem hiding this comment.
Should change "fast-channel" to "Fast-channel"?
Assume this is a term.
There was a problem hiding this comment.
In headings its ok, else where it looks odd with capital Fast-channel. So i have used "fast-channel" in the text and "Fast-channel" in headings
The Performance Feedback fast channel for each application processor will be used by the application processor to fetch frequency whenever its changes. This is required for the estimation of the delivered performance in cases when platform does not provide any hardware counter for the same Signed-off-by: Rahul Pathak <[email protected]>
pathakraul
force-pushed
the
cppc_fastchan_freq
branch
from
5f48bbd
to
ad684b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Hard ID parameter from Fastchannel region request
Convert functions names to monospace in rpmi mpxy chapter
Add Perf Feedback Fastchannel in CPPC ServiceGroup