MM Service Group Improvments #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MM_COMPLETE service of the management mode service group is not needed since it is replaced by the REQUEST_FORWARD service group. Signed-off-by: Anup Patel <[email protected]>
avpatel
force-pushed
the
mm_svcgrp_imp_v1
branch
from
9602e4c
to
46a51f6
Compare
lftan
reviewed
Oct 15, 2024
| |=== | ||
| | Word | ||
| | Name | ||
| | Type | ||
| | Description | ||
|
|
||
| | 0 | ||
| | MM_COMM_DATA_ADDR_LOW |
There was a problem hiding this comment.
MM_COMMUNICATE description section, still using 'MM_COMM_DATA'
There was a problem hiding this comment.
Addressed your comment
Improve the management mode service group as follows: 1) Use MM shared memory to exchange data with MM service 2) Rename MM_VERSION service to MM_GET_ATTRIBUTES service which returns MM version and MM shared memory location. Signed-off-by: Anup Patel <[email protected]>
avpatel
force-pushed
the
mm_svcgrp_imp_v1
branch
from
46a51f6
to
33e542d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.