Improves all chapters #75
Conversation
lftan
force-pushed
the
improve
branch
3 times, most recently
from
146b202
to
fe977c0
Compare
src/intro.adoc
Outdated
| @@ -40,24 +40,24 @@ microcontroller. An RPMI transport instance is associated to a particular | |||
| RISC-V privilege level of the application processors and it must be accessed | |||
| only by that RISC-V privilege level. | |||
|
|
|||
| *RPMI Messaging Protocol*: The RPMI messaging protocol includes different | |||
| types of RPMI messages and the format each RPMI message type. | |||
| *RPMI Messaging Protocol*: The RPMI messaging protocol defined different | |||
src/srvgrp-device-power.adoc
Outdated
| @@ -116,7 +116,7 @@ encoding for the power state. | |||
|
|
|||
| [#device-power-notifications] | |||
| ==== Notifications | |||
| This service group does not support any event for notification. | |||
| This service group does not support event notifications. | |||
There was a problem hiding this comment.
This is giving the incorrect meaning
This section in all the service groups defines EVENTs which are available for notification or for notification message. If NO event is defined then "no event for notification"
The changed line "does not support event notifications" is talking more about the functionality - the Event Notifications functionality is not supported.
There was a problem hiding this comment.
This comment applied to all the service groups
There was a problem hiding this comment.
ok, will update this
src/srvgrp-system-suspend.adoc
Outdated
|
|
||
| ==== Service: SYSSUSP_ENABLE_NOTIFICATION (SERVICE_ID: 0x01) | ||
| This service allows the application processor to subscribe to `SYSTEM_SUSPEND` | ||
| service group defined events for notification. The platform can optionally | ||
| This service allows the application processor to subscribe to events defined by |
There was a problem hiding this comment.
This format must then be used in all service groups *_ENABLE_NOTIFICATION service
There was a problem hiding this comment.
I see only few service groups are changed. I also dont think the earlier line had issues.
Either one, Old or new, must be same for every service group
There was a problem hiding this comment.
standardized to all sections.
Fixes grammars and rephrased some sentences for concisens. Signed-off-by: Ley Foon Tan <[email protected]>
Fixes grammars and rephrased some sentences for concisens.