Fixes across specification in the post ARC review spec #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathakraul
force-pushed
the
rpathak_post_arcdraft
branch
from
9fa5f07
to
e115da2
Compare
avpatel
reviewed
Nov 8, 2024
src/intro.adoc
Outdated
| custom RPMI service groups. | ||
| to the application processors are grouped into RPMI service groups based on | ||
| functionality. Each RPMI service group specifies the RISC-V privilege levels | ||
| from which the application processor can be access it. Platform vendors can |
There was a problem hiding this comment.
s/can be access/can access/
avpatel
reviewed
Nov 8, 2024
src/srvgrp-system-reset.adoc
Outdated
| @@ -187,8 +184,8 @@ default. System Warm Reset support can be discovered with this service. | |||
| This service is used to initiate the system reset or system shutdown. | |||
| The application processor must only request supported reset types, discovered | |||
| using the `SYSRST_GET_ATTRIBUTES` service except for System Shutdown and System | |||
| Cold Reset which are supported by default. Requesting an unsupported or | |||
| invalid reset type may result in the system entering a non-functional state. | |||
| Cold Reset which are supported by default. This service does not return in case | |||
There was a problem hiding this comment.
s/does not return/does not return response message/
Signed-off-by: Rahul Pathak <[email protected]>
Signed-off-by: Rahul Pathak <[email protected]>
RPMI_ERR_BAD_RANGE is meant for bad or invalid ranges of either index or offsets or addresses or just any plain number. Remove index word from the definition and make it generic Signed-off-by: Rahul Pathak <[email protected]>
The base service BASE_GET_HW_INFO was changed to BASE_GET_PLATFORM_INFO but table still mentioned the old name. Correct the right name in the service table in base service group Signed-off-by: Rahul Pathak <[email protected]>
Signed-off-by: Rahul Pathak <[email protected]>
…UTES SYSRST_GET_ATTRIBUTES has flag which can encode if the provided RESET_TYPE is supported, not supported or invalid. Remove the RESET_TYPE invalid error from the status Signed-off-by: Rahul Pathak <[email protected]>
…TTRIBUTES SYSSUSP_GET_ATTRIBUTES as flag which can encode if the provided SUSPEND_TYPE is supported, not supported or invalid. Remove the SUSPEND_TYPE invalid error from the status Signed-off-by: Rahul Pathak <[email protected]>
SYSRST_RESET service can return if the service does not complete successfully. Add the possible error codes Signed-off-by: Rahul Pathak <[email protected]>
Currently in some service groups the error code for an invalid index in an array provided as an input in the request message is RPMI_ERR_BAD_RANGE. But input is not provided as a range but a index and RPMI_ERR_INVALID_PARAM is more appropriate error code Signed-off-by: Rahul Pathak <[email protected]>
Signed-off-by: Rahul Pathak <[email protected]>
Signed-off-by: Rahul Pathak <[email protected]>
pathakraul
force-pushed
the
rpathak_post_arcdraft
branch
from
e115da2
to
1b1cb68
Compare
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only fixes to the existing specification which are misleading and incorrect.