More feedback based changes

Signed Off by: Vasu Srinivasan <[email protected]>

src/chapter2.adoc

@@ -12,9 +12,18 @@ and resources in the system. The topology is expressed in terms of the location
 of the resources within the system and the relation between teh QoS Controller
 and the resource it manages.
 
-When QoS is enabled, all QoS Controllers must be configured to
+When QoS is enabled, all QoS Controllers must be configured properly to
 support proper operation.
 
+[NOTE]
+The RQSC table describes controllers in a flat hierarchy with the actual
+resources each controller is associated with capturing any hierarchy of
+implementation. For example, if an SoC implements a Cache Capacity QoS
+controller for both an L2 cache within a core/cluster of cores and an LLC
+cache, the specific hierarchy information is captured by the resource
+association of the described controllers in terms of the Cache ID field
+of individual PPTT descriptions.
+
 The table format is described in <<RQSC_TABLE>>.
 
 .The RQSC Table
@@ -121,10 +130,11 @@ The table format is described in <<RQSC_TABLE>>.
 <|- Resource ID Type            |1  |7  <a|Type of the Resource ID described by
                                             Resource ID 1 and Resource ID 2 fields.
 
-                                            - 0 - Cache ID
-                                            - 1 - Proximity Domain (Memory)
+                                            - 0 - Cache
+                                            - 1 - Memory Affinity Structure
                                             - 2 - ACPI Device
-                                            - 3 - 0x7F - Reserved for future use
+                                            - 3 - PCI Device
+                                            - 4 - 0x7F - Reserved for future use
                                             - 0x80 - 0xFF - Vendor Specific
 <|- Resource ID 1               |8  |8  <a|Depends on the Resource ID Type field. Refer
                                             to <<RESOURCE_ID_1_TABLE>> for details.
@@ -139,14 +149,7 @@ The table format is described in <<RQSC_TABLE>>.
 [cols="^1,^3",stripes=even,options="header,unbreakable"]
 |===
 |Bit {set:cellbgcolor:green}|Description
-2+<|{set:cellbgcolor:!} *Resource Type [0 - Cache]*
-<|0-7                                   <a|Reserved for future use.
-<|8-15                                  <a|Vendor Specific.
-2+<|*Resource Type [1 - Memory]*
-<|0                                     <a|Raw Bandwidth per bandwidth block is valid
-<|1-7                                   <a|Reserved for future use.
-<|8-15                                  <a|Vendor Specific.
-2+<|*All Other Resource Types*
+2+<|{set:cellbgcolor:!} *All Other Resource Types*
 <|0-7                                   <a|Reserved for future use.
 <|8-15                                  <a|Vendor Specific.
 |===
@@ -164,9 +167,9 @@ The table format is described in <<RQSC_TABLE>>.
                                             ACPI Specification 6.5) that this
                                             controller is associated with.
 <| Reserved                    |4   |4  <a|Reserved.
-4+<|*Resource ID Type [1 - Proximity Domain (Memory)]*
-<| Proximity Domain            |4   |0   <a|Proximity domain from the SRAT table
-                                            that this specific controller is
+4+<|*Resource ID Type [1 - Memory Affinity Structure]*
+<| Proximity Domain            |4   |0   <a|Proximity domain from the SRAT table's
+                                            Memory Affinity Structure the resource is
                                             associated with. If the SRAT
                                             table is not implemented, then this value
                                             shall be 0 indicating a UMA memory
@@ -175,6 +178,11 @@ The table format is described in <<RQSC_TABLE>>.
 4+<|*Resource ID Type [2 - ACPI Device]*
 <| ACPI Hardware ID            |8   |0   <a|_HID value of the ACPI Device
                                             corresponding to the Resource.
+4+<|*Resource ID Type [3 - PCI Device]*
+<| BDF                         |4   |0   <a|The Segment/Bus/Device/Function data
+                                            of the resource that this controller
+                                            is associated with.
+<| Reserved                    |4   |4  <a|Reserved.
 |===
 
 .Resource ID 2