chore: add rule and test #851
Conversation
Signed-off-by: caicancai <[email protected]>
|
cc @wangrunji0408 If you have time, could you help me review this PR? Thank you. |
src/planner/rules/plan.rs
Outdated
| " | ||
| proj (list $1.2) | ||
| (limit 10 0 | ||
| (order (list) |
There was a problem hiding this comment.
This is an empty ordering. Should be (order (list $1.2) ..)?
There was a problem hiding this comment.
Thanks, fix
But the fact that rust test can pass means there is still room for improvement. I will find time to improve it.
Signed-off-by: caicancai <[email protected]>
|
@wangrunji0408 PATL, thank you |
Co-authored-by: Runji Wang <[email protected]> Signed-off-by: Cancai Cai <[email protected]>
|
@wangrunji0408 I would like to ask a question, can egg+sql optimization be extracted into a separate framework and then integrated with calcite? Do you think this is feasible? |
I'm not sure as the Calcite is written in Java while egg is designed for Rust. Besides, what's the purpose of doing this? As far as I know, the Calcite itself is a framework for optimization. I have always thought of egg as a Rust alternative of Calcite. |
I think it is a bit complicated to expand an optimization rule in Calcite at present, and it is not as convenient as egg. My original intention is to make Calcite more convenient to use. |
I noticed that risinglight uses egg for CBO optimization, but it looks violent at the moment. I will try to optimize it.