Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use in-memory storage by default #859

Merged
merged 2 commits into from
Dec 3, 2024
Merged

feat: use in-memory storage by default #859

merged 2 commits into from
Dec 3, 2024

Conversation

wangrunji0408
Copy link
Member

To keep consistent with sqlite and duckdb:

risinglight # use in-memory storage
risinglight test.db # use disk storage

@wangrunji0408
remove --memory
9685ff2 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 requested a review from skyzh December 3, 2024 14:43
@wangrunji0408
fix ci
35bd871 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit fe6ff85 Dec 3, 2024
5 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/memory-by-default branch December 3, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TennyZhuang TennyZhuang TennyZhuang approved these changes

@skyzh skyzh Awaiting requested review from skyzh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangrunji0408 @TennyZhuang