Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description for SQL references #2632

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Update description for SQL references #2632

merged 8 commits into from
Sep 25, 2024

Conversation

WanYixian
Copy link
Contributor

@WanYixian WanYixian commented Sep 23, 2024

Description

Some descriptions for SQL commands, query syntax, functions & operators, system catalogs are exactly the same as title, so modify them.

Related doc issue

Resolve #2594

Rendered preview

https://pr-2632.d2fbku9n2b6wde.amplifyapp.com/docs/next/query-syntax/

Checklist

  • I have checked the doc site preview, and the updated parts look good.
  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (emile-00, hengm3467, & WanYixian).

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2632.d2fbku9n2b6wde.amplifyapp.com

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sql functions" page is not updated https://pr-2632.d2fbku9n2b6wde.amplifyapp.com/docs/next/sql-functions/ (which is origninal issue in #2594

Changes of "sql syntax" generally LGTM

docs/sql/commands/sql-create-sink.md Outdated Show resolved Hide resolved
docs/sql/commands/sql-set-background-ddl.md Outdated Show resolved Hide resolved
docs/sql/commands/sql-set-time-zone.md Outdated Show resolved Hide resolved
@xxchan xxchan requested a review from stdrc September 24, 2024 10:59
@WanYixian WanYixian changed the title Update description for SQL commands and query syntax Update description for SQL references Sep 25, 2024
@WanYixian
Copy link
Contributor Author

Updated, please take another look.

Copy link
Contributor

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

docs/sql/query-syntax/query-syntax-generated-columns.md Outdated Show resolved Hide resolved
@WanYixian WanYixian merged commit a66acd7 into main Sep 25, 2024
3 checks passed
@WanYixian WanYixian deleted the wyx/resolve_2594 branch September 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: abstract in "SQL functions and operators" is not helpful
4 participants