Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sink-to-postgres.md: upsert also can issue DELETEs downstream #2633

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

kwannoel
Copy link
Contributor

Description

Upsert semantics allows deletes to be emitted downstream as well. We should clarify that to users.

Related code PR

Related doc issue

Resolve

Rendered preview

Checklist

  • I have checked the doc site preview, and the updated parts look good.
  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (emile-00, hengm3467, & WanYixian).

@kwannoel kwannoel changed the title Update sink-to-postgres.md Update sink-to-postgres.md: upsert also can issue DELETEs downstream Sep 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2633.d2fbku9n2b6wde.amplifyapp.com

@WanYixian
Copy link
Contributor

LGTM, thanks! If this also applies to the next version, pls also add it to the next (2.1) version?

@kwannoel
Copy link
Contributor Author

kwannoel commented Sep 24, 2024

LGTM, thanks! If this also applies to the next version, pls also add it to the next (2.1) version?
Done

@kwannoel kwannoel merged commit cd665a8 into main Sep 24, 2024
2 of 3 checks passed
@kwannoel kwannoel deleted the kwannoel-patch-2 branch September 24, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants