Skip to content

Commit

Permalink
Revert "Don't specify an unnecessary config given that tox task and g…
Browse files Browse the repository at this point in the history
…radle config already defines the Python version." (apache#31283)

* Revert "Don't specify an unnecessary config given that tox task and gradle config already defines the Python version."

This reverts commit 3ca2c5f.

* Trigger tests
  • Loading branch information
tvalentyn authored May 14, 2024
1 parent 5c5bccc commit c061b27
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 7 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs="--ignore=apache_beam/dataframe/ --ignore=apache_beam/ml/ --ignore=apache_beam/examples/ --ignore=apache_beam/runners/ --ignore=apache_beam/transforms/"
-Pposargs="--ignore=apache_beam/dataframe/ --ignore=apache_beam/ml/ --ignore=apache_beam/examples/ --ignore=apache_beam/runners/ --ignore=apache_beam/transforms/" \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Dataframes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/dataframe/
-Pposargs=apache_beam/dataframe/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/examples/
-Pposargs=apache_beam/examples/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_ML.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:testPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}ML
arguments: |
-Pposargs=apache_beam/ml/
-Pposargs=apache_beam/ml/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Runners.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/runners/
-Pposargs=apache_beam/runners/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Transforms.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/transforms/
-Pposargs=apache_beam/transforms/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/transforms/sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class SqlTransform(ExternalTransform):
`apache_beam.examples.wordcount_xlang_sql`, `apache_beam.examples.sql_taxi`,
and `apache_beam.transforms.sql_test`.
For more details about Beam SQL in general see the `Java transform
For more details about Beam SQL in general, see the `Java transform
<https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/extensions/sql/SqlTransform.html>`_,
and the `documentation
<https://beam.apache.org/documentation/dsls/sql/overview/>`_.
Expand Down

0 comments on commit c061b27

Please sign in to comment.