Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Issue with formData not updating when dependencies change #4388

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Bug: Issue with formData not updating when dependencies change #4388

wants to merge 17 commits into from

Conversation

abdalla-rko
Copy link
Contributor

Reasons for making this change

Fixes #4325

Checklist

  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR

heath-freenome
heath-freenome requested changes Nov 22, 2024
View reviewed changes
packages/utils/src/mergeDefaultsWithFormData.ts Outdated Show resolved Hide resolved
packages/utils/src/mergeDefaultsWithFormData.ts Outdated Show resolved Hide resolved
packages/utils/src/mergeDefaultsWithFormData.ts Outdated Show resolved Hide resolved
packages/utils/src/schema/getDefaultFormState.ts Outdated Show resolved Hide resolved
packages/utils/src/schema/getDefaultFormState.ts Outdated Show resolved Hide resolved
packages/utils/src/schema/getDefaultFormState.ts Outdated Show resolved Hide resolved
packages/utils/src/schema/getDefaultFormState.ts Outdated Show resolved Hide resolved
packages/utils/test/schema/getDefaultFormStateTest.ts Outdated Show resolved Hide resolved
@heath-freenome
Copy link
Member

@abdalla-rko Can you fix the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heath-freenome heath-freenome heath-freenome requested changes

@nickgros nickgros nickgros left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default values not changing when dependencies updated
3 participants
@abdalla-rko @heath-freenome @nickgros