-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enhanced sysinfo.py #163
feat: add enhanced sysinfo.py #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! See inline comments.
No problem, I'll check it out after work, takes about 9 hours later (I'm here in South Korea). |
|
@thijstriemstra any updates? |
I just got back from holidays, let me take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the qa task if failing due to some lint errors, run
tox -e qa
locally and/or see https://github.com/rm-hull/luma.examples/actions/runs/6017087533/job/16684187858?pr=163#step:8:24 for these errors. - can you add a docstring to the example with a description of the enhancements you made?
- At first I thought this new code could replace the existing sys_info.py but not sure, maybe it's better separate like this, thoughts @rm-hull?
- the filename is not very descriptive, maybe it could be called
sys_info_extended.py
or something like that. - the new example needs to be added to the README.md
- add your name to CONTRIBUTING.rst
I've made some edits. I'm not a Python guy, so I'm not sure if I did it correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
I created enhanced sysinfo.py (sys_info2.py) like below.
New design, and source code refinement.
Also, every 4 seconds UpTime and Ip toggled automatically.
If CPU or Mem or Disk reach 100%, it shows more clearly.
Tested on
(GeeekPi Raspberry PI NAS mini tower Kit)
fixes #159