Skip to content

Commit

Permalink
Don't require a base layer
Browse files Browse the repository at this point in the history
  • Loading branch information
rmohr committed Nov 15, 2018
1 parent 0abab66 commit 32befa1
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rpm/install_rpms.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
parser = argparse.ArgumentParser(
description='Install RPMs and update the RPM database inside the docker image')

parser.add_argument('--uncompressed_layer', action='append', required=True,
help='The output file, mandatory')
parser.add_argument('--uncompressed_layer', action='append', required=False,
help='The output file, mandatory', default=[])

parser.add_argument('--rpm', action='append', required=True,
help=('rpms to add to the database'))
Expand Down
6 changes: 6 additions & 0 deletions test/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,9 @@ container_test(
configs = ["configs/allinone.yaml"],
image = "//testdata:allinone",
)

container_test(
name = "allinone_no_base_test",
configs = ["configs/allinone.yaml"],
image = "//testdata:allinone_no_base",
)
5 changes: 5 additions & 0 deletions testdata/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ rpm_image(
rpms = ["@glibc//file", "@ca_certificates//file"],
)

rpm_image(
name = "allinone_no_base",
rpms = ["@glibc//file", "@ca_certificates//file"],
)

rpm_image(
name = "image2",
base = ":image1",
Expand Down

0 comments on commit 32befa1

Please sign in to comment.