Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite results changes #287

Merged
merged 8 commits into from
Sep 25, 2023
Merged

Conversation

robbievanleeuwen
Copy link
Owner

@robbievanleeuwen robbievanleeuwen commented Sep 24, 2023

New implementation for getting cross-section property results, fixes #272.

New behaviour can be summarised as follows:

  • First considers whether the analysis is purely geometric (no material properties applied) or composite (material properties applied).
  • The following methods are modified or added (if the wrong analysis has been conducted i.e. geometric vs. composite, will raise an error with a helpful suggestion):
    • get_mass() (composite only), if geometric suggests to use get_area()
    • get_ea() (composite only), if geometric suggests to use get_area()
    • get_q() (geometric only), if composite suggests to use get_eq()
    • get_eq() (composite only), if geometric suggests to use get_q()
    • get_ig() (geometric only), if composite suggests to use get_eig()
    • get_eig() (composite only), if geometric suggests to use get_ig()
    • get_ic() (geometric only), if composite suggests to use get_eic()
    • get_eic() (composite only), if geometric suggests to use get_ic()
    • get_z() (geometric only), if composite suggests to use get_ez()
    • get_ez() (composite only), if geometric suggests to use get_z()
    • get_ip() (geometric only), if composite suggests to use get_eip()
    • get_eip() (composite only), if geometric suggests to use get_ip()
    • get_zp() (geometric only), if composite suggests to use get_ezp()
    • get_ezp() (composite only), if geometric suggests to use get_zp()
    • get_nu_eff(), get_e_eff(), get_g_eff() (composite only)
    • get_j() (geometric only), if composite suggests to use get_ej()
    • get_ej() (composite only), if geometric suggests to use get_j()
    • get_gamma() (geometric only), if composite suggests to use get_egamma()
    • get_egamma() (composite only), if geometric suggests to use get_gamma()
    • get_as() (geometric only), if composite suggests to use get_eas()
    • get_eas() (composite only), if geometric suggests to use get_as()
    • get_as_p() (geometric only), if composite suggests to use get_eas_p()
    • get_eas_p() (composite only), if geometric suggests to use get_as_p()
    • get_s() (geometric only), if composite suggests to use get_mp()
    • get_mp() (composite only), if geometric suggests to use get_s()
    • get_sp() (geometric only), if composite suggests to use get_mp_p()
    • get_mp_p() (composite only), if geometric suggests to use get_sp()
    • get_sf(), get_sf_p() (geometric only)
  • The option to use a reference elastic modulus to obtain transformed properties is provided where applicable

@robbievanleeuwen robbievanleeuwen added engineering Issue related to engineering methods/assumptions documentation Improvements or additions to documentation labels Sep 24, 2023
@robbievanleeuwen robbievanleeuwen self-assigned this Sep 24, 2023
@robbievanleeuwen robbievanleeuwen marked this pull request as ready for review September 24, 2023 12:05
@robbievanleeuwen robbievanleeuwen merged commit 35a7b65 into hypermodern Sep 25, 2023
25 checks passed
@robbievanleeuwen robbievanleeuwen deleted the composite-results-changes branch September 25, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation engineering Issue related to engineering methods/assumptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior calculating 2nd Moments of Area (.get_ic) with Material
1 participant