Strict Concurrency #109

radianttap · 2024-04-16T15:06:27Z

Sprinkled Sendable and @MainActor as needed.
Converted few vars into let.
Set strict-concurrency-checking to Complete.
Moved minimum deployment to iOS 15, tvOS 15, macOS 10.15 (concurrency aware versions).
Updated version info to 5.0 — I recommend to tag as such.

Turned-off BITCODE Moved minimum deployment to iOS 15, tvOS 15, macOS 10.15 Set strict concurrency checking to Complete.

This is entirely UI-bound thus it's all in main thread.

SomeRandomiOSDev · 2024-07-25T20:58:48Z

TinyConstraints/Classes/Constrainable.swift

    @discardableResult
    public func prepareForLayout() -> Self { return self }
 }

-public protocol Constrainable {
+@MainActor public protocol Constrainable {


Strongly recommend the following instead:

Suggested change

@MainActor public protocol Constrainable {

@preconcurrency @MainActor

public protocol Constrainable {

This makes it so that existing code that doesn't yet have strict concurrency enabled can use this library version without having to make changes to their code.

SomeRandomiOSDev · 2024-07-25T20:59:38Z

TinyConstraints/Classes/Constrainable.swift

@@ -36,12 +36,12 @@ extension TinyView: Constrainable {
    }
 }

-extension LayoutGuide: Constrainable {
+@MainActor extension LayoutGuide: Constrainable {


Not needed as the compiler infers @MainActor isolation for all members declared on this extension since Constrainable is isolated to the @MainActor.

Suggested change

@MainActor extension LayoutGuide: Constrainable {

extension LayoutGuide: Constrainable {

SomeRandomiOSDev · 2024-07-25T20:59:41Z

TinyConstraints/Classes/Constrainable.swift

@@ -27,7 +27,7 @@
    import UIKit
 #endif

-extension TinyView: Constrainable {
+@MainActor extension TinyView: Constrainable {


Not needed as the compiler infers @MainActor isolation for all members declared on this extension since Constrainable is isolated to the @MainActor.

Suggested change

@MainActor extension TinyView: Constrainable {

extension LayoutGuide: Constrainable {

SomeRandomiOSDev · 2024-07-25T21:00:55Z

TinyConstraints/Classes/Constraints.swift

    case equal = 0
    case equalOrLess = -1
    case equalOrGreater = 1
 }

-public extension Collection where Iterator.Element == Constraint {
+@MainActor public extension Collection where Iterator.Element == Constraint {


Strongly recommend the following instead:

Suggested change

@MainActor public extension Collection where Iterator.Element == Constraint {

@preconcurrency @MainActor

public extension Collection where Iterator.Element == Constraint {

This makes it so that existing code that doesn't yet have strict concurrency enabled can use this library version without having to make changes to their code.

SomeRandomiOSDev · 2024-07-25T21:01:29Z

TinyConstraints/Classes/Constraints.swift

@@ -55,7 +55,7 @@ public extension Collection where Iterator.Element == Constraint {
 }

 #if os(OSX)
-public extension Constraint {
+@MainActor public extension Constraint {


Not needed since Constraint is already isolated to the @MainActor

Suggested change

@MainActor public extension Constraint {

public extension Constraint {

SomeRandomiOSDev · 2024-07-25T21:01:32Z

TinyConstraints/Classes/Constraints.swift

@@ -68,7 +68,7 @@ public extension Constraint {
    }
 }
 #else
-    public extension Constraint {
+@MainActor public extension Constraint {


Not needed since Constraint is already isolated to the @MainActor

Suggested change

@MainActor public extension Constraint {

public extension Constraint {

SomeRandomiOSDev · 2024-07-25T21:01:44Z

TinyConstraints/Classes/Stack.swift

@@ -28,7 +28,7 @@
    import UIKit
 #endif

-public extension TinyView {
+@MainActor public extension TinyView {


Not needed since TinyView is already isolated to the @MainActor

Suggested change

@MainActor public extension TinyView {

public extension TinyView {

SomeRandomiOSDev · 2024-07-25T21:01:50Z

TinyConstraints/Classes/TinyConstraints+superview.swift

@@ -25,7 +25,7 @@
 #if os(OSX)
    import AppKit

-    public extension TinyView {
+@MainActor public extension TinyView {


Not needed since TinyView is already isolated to the @MainActor

Suggested change

@MainActor public extension TinyView {

public extension TinyView {

SomeRandomiOSDev · 2024-07-25T21:01:54Z

TinyConstraints/Classes/TinyConstraints+superview.swift

@@ -53,7 +53,7 @@
 #else
    import UIKit

-    public extension TinyView {
+@MainActor public extension TinyView {


Not needed since TinyView is already isolated to the @MainActor

Suggested change

@MainActor public extension TinyView {

public extension TinyView {

SomeRandomiOSDev · 2024-07-25T21:02:00Z

TinyConstraints/Classes/TinyConstraints+superview.swift

@@ -164,7 +164,7 @@ public struct LayoutEdge: OptionSet {
    public static let none = LayoutEdge(rawValue: 1 << 6)
 }

-public extension TinyView {
+@MainActor public extension TinyView {


Not needed since TinyView is already isolated to the @MainActor

Suggested change

@MainActor public extension TinyView {

public extension TinyView {

SomeRandomiOSDev · 2024-07-25T21:02:54Z

TinyConstraints/Classes/TinyConstraints.swift

@@ -28,7 +28,7 @@
    import UIKit
 #endif

-public extension Constrainable {
+@MainActor public extension Constrainable {


Not needed since Constrainable is already isolated to the @MainActor

Suggested change

@MainActor public extension Constrainable {

public extension Constrainable {

SomeRandomiOSDev · 2024-07-25T21:03:11Z

TinyConstraints/Classes/TinyConstraints.swift

@@ -339,7 +339,7 @@ public extension Constrainable {
    }
 }

-public extension TinyView {
+@MainActor public extension TinyView {


Not needed since TinyView is already isolated to the @MainActor

Suggested change

@MainActor public extension TinyView {

public extension TinyView {

SomeRandomiOSDev · 2024-07-25T21:03:56Z

TinyConstraints/Classes/TinyEdgeInsets.swift

@@ -28,7 +28,7 @@
    import UIKit
 #endif

-extension TinyEdgeInsets {
+@MainActor extension TinyEdgeInsets {


It's probably not recommended to add this since TinyEdgeInsets itself isn't isolated to the @MainActor and there's no code in any of these members that requires @MainActor isolation

kimdv · 2024-09-13T05:49:37Z

Any news on this or should someone else take over? 😁

SomeRandomiOSDev · 2024-09-17T13:19:45Z

I made all of the changes locally and was about to put up a PR myself before noticing this one. I don’t have an issue pushing my changes and opening a PR myself 🤷🏻‍♂️

radianttap · 2024-09-18T08:50:56Z

I made all of the changes locally and was about to put up a PR myself before noticing this one. I don’t have an issue pushing my changes and opening a PR myself 🤷🏻‍♂️

Feel free and let me know, I'll close this. I have no time at the moment to work this out further.

radianttap added 3 commits April 16, 2024 16:52

Updated to recommended settings from Xcode 15.3

b1e4822

Turned-off BITCODE Moved minimum deployment to iOS 15, tvOS 15, macOS 10.15 Set strict concurrency checking to Complete.

Marked Sendable and @mainactor where needed.

cc958f3

This is entirely UI-bound thus it's all in main thread.

Updated auxiliary files.

0973de0

SomeRandomiOSDev reviewed Jul 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Strict Concurrency #109

Strict Concurrency #109

radianttap commented Apr 16, 2024

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024

SomeRandomiOSDev Jul 25, 2024

SomeRandomiOSDev Jul 25, 2024

SomeRandomiOSDev Jul 25, 2024

SomeRandomiOSDev Jul 25, 2024

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024

SomeRandomiOSDev Jul 25, 2024

SomeRandomiOSDev Jul 25, 2024

kimdv commented Sep 13, 2024

SomeRandomiOSDev commented Sep 17, 2024

radianttap commented Sep 18, 2024

	@MainActor public protocol Constrainable {
	@preconcurrency @MainActor
	public protocol Constrainable {

	@MainActor extension LayoutGuide: Constrainable {
	extension LayoutGuide: Constrainable {

	@MainActor extension TinyView: Constrainable {
	extension LayoutGuide: Constrainable {

	@MainActor public extension Collection where Iterator.Element == Constraint {
	@preconcurrency @MainActor
	public extension Collection where Iterator.Element == Constraint {

	@MainActor public extension Constraint {
	public extension Constraint {

	@MainActor public extension TinyView {
	public extension TinyView {

	@MainActor public extension Constrainable {
	public extension Constrainable {

Strict Concurrency #109

Are you sure you want to change the base?

Strict Concurrency #109

Conversation

radianttap commented Apr 16, 2024

SomeRandomiOSDev Jul 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SomeRandomiOSDev Jul 25, 2024 • edited Loading

Choose a reason for hiding this comment

SomeRandomiOSDev Jul 25, 2024 • edited Loading

Choose a reason for hiding this comment

SomeRandomiOSDev Jul 25, 2024 • edited Loading

Choose a reason for hiding this comment

SomeRandomiOSDev Jul 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kimdv commented Sep 13, 2024

SomeRandomiOSDev commented Sep 17, 2024

radianttap commented Sep 18, 2024

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading

SomeRandomiOSDev Jul 25, 2024 •

edited

Loading