Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer.json): update runArgs array elements to use equals sign instead of commas for name value assignment [or] style(devcontainer.json): conform JSON keys and values to use double quotes and consistent formatting. #319

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

robinmordasiewicz
Copy link
Owner

@robinmordasiewicz robinmordasiewicz commented Mar 30, 2024

Updates the runArgs array elements in the .devcontainer/devcontainer.json file to use equals signs instead of commas for name value assignment. By making this change, we ensure consistency and clarity in the configuration settings of our development container.

The updated format "runArgs": ["--name=devops-toolkit", "--hostname=devops-toolkit"] enhances the readability and maintainability of the configuration file, aligning with best practices for JSON key-value pairs.

This improvement streamlines the configuration process and promotes a more standardized and organized approach to defining container runtime arguments.

…sign instead of commas for name value assignment

[or]
style(devcontainer.json): conform JSON keys and values to use double quotes and consistent formatting.
@robinmordasiewicz robinmordasiewicz merged commit b001f9a into main Mar 30, 2024
7 of 8 checks passed
@robinmordasiewicz robinmordasiewicz deleted the removegpu branch March 30, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant