Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit(.pre-commit-config.yaml): remove commented out terraform\_docs hook configuration to simplify file and improve readability #337

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

robinmordasiewicz
Copy link
Owner

[Note: The commit message should not include the comment about the reason for removing the commented out lines as it is assumed that the developer has a good reason for doing so.]

Name Description
+ admin_password
+ admin_username
+ hub-nva-management_public_ip
+ hub-nva-vip_public_ip
+ resource_group_name
+ spoke-nva_private_ip
+ spoke-nva_public_ip

refactor(output): add labels to output properties for better documentation and navigation in the generated output.

refactor: update Fortigate configuration and Terraform outputs

  • Change Fortigate config to allow inbound traffic on port 443 for the waf profile (git diff a/terraform/cloud-init/fortigate.conf b/terraform/cloud-init/fortigate.conf)
  • Remove unused outputs for hub-nva-vip-public-ip and hub-nva-management-public-ip in outputs.tf (git diff a/terraform/outputs.tf b/terraform/outputs.tf)
  • Add new outputs for admin_username, admin_password, management_fqdn, vip_fqdn in outputs.tf (new file mode 100644 a/terraform/outputs.tf)
  • Update Terraform test configuration to assert Terraform version is 1.8.0 instead of 1.6.2 (git diff a/terraform/terraform.tftest.hcl b/terraform/terraform.tftest.hcl)

robinmordasiewicz and others added 2 commits April 15, 2024 16:00
…s hook configuration to simplify file and improve readability

[Note: The commit message should not include the comment about the reason for removing the commented out lines as it is assumed that the developer has a good reason for doing so.]

 | Name | Description |
 |------|-------------|
+| admin\_password | Password for admin account. |
+| admin\_username | Username for admin account. |
+| hub-nva-management\_public\_ip | Management IP address. |
+| hub-nva-vip\_public\_ip | Virtual IP address for Hub NVA. |
+| resource\_group\_name | Name of the Azure Resource Group. |
+| spoke-nva\_private\_ip | Private IP address for Spoke NVA. |
+| spoke-nva\_public\_ip | Public IP address for Spoke NVA. |

 refactor(output): add labels to output properties for better documentation and navigation in the generated output.

 refactor: update Fortigate configuration and Terraform outputs

- Change Fortigate config to allow inbound traffic on port 443 for the waf profile (git diff a/terraform/cloud-init/fortigate.conf b/terraform/cloud-init/fortigate.conf)
- Remove unused outputs for hub-nva-vip-public-ip and hub-nva-management-public-ip in outputs.tf (git diff a/terraform/outputs.tf b/terraform/outputs.tf)
- Add new outputs for admin\_username, admin\_password, management\_fqdn, vip\_fqdn in outputs.tf (new file mode 100644 a/terraform/outputs.tf)
- Update Terraform test configuration to assert Terraform version is 1.8.0 instead of 1.6.2 (git diff a/terraform/terraform.tftest.hcl b/terraform/terraform.tftest.hcl)
Copy link
Contributor

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.38s
✅ MARKDOWN markdownlint 1 1 0 0.78s
✅ MARKDOWN markdown-table-formatter 1 1 0 0.49s
✅ REPOSITORY checkov yes no 18.56s
✅ REPOSITORY dustilock yes no 1.34s
❌ REPOSITORY gitleaks yes 1 24.48s
✅ REPOSITORY git_diff yes no 0.09s
✅ REPOSITORY grype yes no 15.25s
❌ REPOSITORY kics yes 29 71.33s
❌ REPOSITORY secretlint yes 1 1.43s
✅ REPOSITORY syft yes no 0.47s
✅ REPOSITORY trivy yes no 8.23s
✅ REPOSITORY trivy-sbom yes no 1.89s
✅ REPOSITORY trufflehog yes no 15.32s
✅ TERRAFORM terraform-fmt 3 0 0 0.39s
✅ TERRAFORM terragrunt 1 0 0 0.31s
✅ TERRAFORM terrascan yes no 10.18s
✅ TERRAFORM tflint yes no 2.44s
✅ YAML prettier 1 0 0 0.5s
✅ YAML v8r 1 0 2.1s
✅ YAML yamllint 1 0 0.47s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@robinmordasiewicz robinmordasiewicz merged commit 8af3595 into main Apr 15, 2024
@robinmordasiewicz robinmordasiewicz deleted the terraform branch April 15, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant