The changes made in the provided code snippet include:

[robinmordasiewicz]

1. Changed the name of the configuration file for custom_data to use the Hub NVAs offer instead of a hardcoded value.
2. Added an azurerm_storage_account and azurerm_storage_container resource to create a storage account and container for boot diagnostics.
3. Updated the boot_diagnostics block to use the newly created storage account and container.
4. Changed the name of the managed disk to be more descriptive and follow naming conventions.
5. Added comments for the removed code that was not needed anymore.

Here's a brief explanation of each change:

1. Using a variable for the configuration file name allows for easier maintenance and flexibility in case the Hub NVA offer changes in the future.
2. Creating an Azure Storage Account and Container for boot diagnostics is a best practice to ensure that the data is securely stored and accessible only by authorized users.
3. Updating the boot_diagnostics block to use the newly created storage account and container ensures that the boot diagnostics are properly configured and stored in the correct location.
4. Renaming the managed disk to follow a more descriptive naming convention makes it easier to understand what the resource is used for.
5. Adding comments for the removed code helps maintain documentation and makes it clear why certain changes were made.

refactor(terraform.auto.tfvars): update FortiNet network security group offer and sku to use the latest version
chore(terraform.auto.tfvars): remove unused hub-nva-offer variable and update new offer and sku values accordingly

[github-actions]

🦙 MegaLinter status: ❌ ERROR

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ COPYPASTE	jscpd	yes		no	1.45s
✅ REPOSITORY	checkov	yes		no	18.43s
✅ REPOSITORY	dustilock	yes		no	2.58s
❌ REPOSITORY	gitleaks	yes		1	23.05s
✅ REPOSITORY	git_diff	yes		no	0.13s
✅ REPOSITORY	grype	yes		no	15.05s
❌ REPOSITORY	kics	yes		29	70.24s
✅ REPOSITORY	secretlint	yes		no	1.39s
✅ REPOSITORY	syft	yes		no	0.36s
✅ REPOSITORY	trivy	yes		no	9.25s
✅ REPOSITORY	trivy-sbom	yes		no	2.97s
✅ REPOSITORY	trufflehog	yes		no	12.66s
✅ TERRAFORM	terraform-fmt	1	0	0	0.08s
✅ TERRAFORM	terrascan	yes		no	12.37s
✅ TERRAFORM	tflint	yes		no	3.51s
✅ YAML	prettier	1	0	0	0.53s
✅ YAML	v8r	1		0	2.41s
✅ YAML	yamllint	1		0	0.71s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by