The changes in this diff are related to renaming some variables and resources names for consistency, specifically the name of the network interface configuration for the NVA's external management IP address. The new name is "hub-nva-external-management\_ip\_configuration" instead of "hub-nva-management-external\_ip\_configuration". This change should not affect the functionality of your infrastructure but it is a good practice to keep consistent names throughout your Terraform configuration files. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resources names for consistency, specifically the name of the network interface configuration for the NVA's external management IP address. The new name is "hub-nva-external-management\_ip\_configuration" instead of "hub-nva-management-external\_ip\_configuration". This change should not affect the functionality of your infrastructure but it is a good practice to keep consistent names throughout your Terraform configuration files. refactor(terraform.auto.tfvars): change hub-nva-management-port from hardcoded value to a variable and set it to "8443" docs(terraform.tf): add new file tls\_private\_key.tf to generate self-signed SSL certificate for Hub NVAs perf(terraform.tf): update Terraform version requirement to >=1.6 for better performance and compatibility with latest features test(terraform.auto.tfvars): add new resource tls\_self\_signed\_cert to create a self-signed SSL certificate for Hub NVAs using the generated private key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(terraform.auto.tfvars): change hub-nva-management-port from hardcoded value to a variable and set it to "8443"
docs(terraform.tf): add new file tls_private_key.tf to generate self-signed SSL certificate for Hub NVAs
perf(terraform.tf): update Terraform version requirement to >=1.6 for better performance and compatibility with latest features
test(terraform.auto.tfvars): add new resource tls_self_signed_cert to create a self-signed SSL certificate for Hub NVAs using the generated private key