Commands QA review #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2024
Closed
virtuald
force-pushed
the
review
branch
4 times, most recently
from
427ac17
to
fe7caee
Compare
virtuald
force-pushed
the
review
branch
10 times, most recently
from
c5f2bb8
to
1a696ca
Compare
TheTripleV
reviewed
Jan 20, 2024
virtuald
force-pushed
the
review
branch
7 times, most recently
from
1703550
to
1cb70ee
Compare
|
Still need to do trigger and the scheduler, but overall everything looks pretty good so far. Bedtime. |
virtuald
force-pushed
the
review
branch
2 times, most recently
from
ab7dd66
to
b51ee56
Compare
TheTripleV
reviewed
Jan 24, 2024
TheTripleV
approved these changes
Jan 24, 2024
- CommandGroup - PerpetualCommand - ProxyScheduleCommand
- self._currentCommandIndex must always be set to -1 in end
- Update docs - Change member variables to be prefixed with _ - Add initSendable
- Remove deprecated functions - Reorder functions to match Java, to make updates easier in the future
- Fixes #32
- Needs LiveWindow fix or tests will hang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be a big one, going through and nit-picking/updating stuff. Will unmark draft once finished.