Fix handling of EOF in lsh_read_line() (brenns10#25)

robsim0116 · Aug 25, 2024 · bb229d8 · bb229d8
1 parent fdf0716
commit bb229d8
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/main.c b/src/main.c
@@ -181,14 +181,19 @@ char *lsh_read_line(void)
     // Read a character
     c = getchar();
 
-    if (c == EOF) {
+    if (c == EOF && feof(stdin)) {
+      free(buffer);
       exit(EXIT_SUCCESS);
+    } else if (c == EOF && ferror(stdin)) {
+      perror("getchar (EOF)");
+      free(buffer);
+      exit(EXIT_FAILURE);
     } else if (c == '\n') {
       buffer[position] = '\0';
       return buffer;
-    } else {
-      buffer[position] = c;
     }
+
+    buffer[position] = c;
     position++;
 
     // If we have exceeded the buffer, reallocate.