-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global instructions #234
base: master
Are you sure you want to change the base?
Global instructions #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job. Few comments, let me know if something isn't clear.
…v/holmesgpt into main-2440-global-instructions
@@ -340,5 +353,4 @@ def build_chat_messages( | |||
ai, conversation_history_without_tools, number_of_tools | |||
) | |||
truncate_tool_messages(conversation_history, tool_size) | |||
|
|||
return conversation_history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversation history is including now the global instructions this means that this what the user will see in the history chat?
No description provided.