Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAIN-2708] Gemini support #238

Merged
merged 18 commits into from
Dec 23, 2024
Merged

[MAIN-2708] Gemini support #238

merged 18 commits into from
Dec 23, 2024
+275 −5

Conversation

Avi-Robusta
Copy link
Contributor

@Avi-Robusta Avi-Robusta commented Dec 19, 2024 •
edited
Loading

Tested on

  • Robusta
  • bedrock/anthropic.claude-3-5-sonnet-20240620-v1:0
  • openai/gpt-4o
  • vertex_ai/gemini-2.0-flash-exp
  • gemini/gemini-pro

@Avi-Robusta Avi-Robusta changed the title Gemini support [MAIN-2708] Gemini support Dec 19, 2024
itisallgood
itisallgood reviewed Dec 20, 2024
View reviewed changes
holmes/core/tools.py Outdated Show resolved Hide resolved
arikalon1
arikalon1 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit 2a01c7e into master Dec 23, 2024
12 checks passed
@arikalon1 arikalon1 deleted the gemini-support branch December 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itisallgood itisallgood itisallgood left review comments

@arikalon1 arikalon1 arikalon1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Avi-Robusta @arikalon1 @itisallgood