-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add holmes generate alertmanager-tests
command
#56
Conversation
and add flags to `holmes investigate alertmanager` to use that data instead of connecting to a live alertmanager
for tests
since it uses the url and its none in the alertmanager source
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
2 changes requested
Good catch, will fix. |
Move contents of holmes.py to holmes/main.py. This is necesssary to make the entrypoint installable. Note: this includes changes from #56 as well, so will be easier to review once that is merged. (I didn't base this PR off master as that would have caused conflicts once #56 is merged as they both touch holmes.py.)
and add flags to
holmes investigate alertmanager
to use that data instead of connecting to a live alertmanager