Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read default config file from ~/.holmes/config.yaml not current directory #61

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

aantn
Copy link
Contributor

@aantn aantn commented Jun 23, 2024

This makes holmes behave like other command line tools (e.g. kubectl) and more like users expect. This came up in a recent user feedback call.

@aantn aantn requested a review from arikalon1 June 23, 2024 12:45
@aantn
Copy link
Contributor Author

aantn commented Jun 23, 2024

@pavangudiwada FYI

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit 7f1f4fd into master Jun 29, 2024
9 checks passed
@arikalon1 arikalon1 deleted the change-config-file-location branch June 29, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants