Label selector argument #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dohnto-s1
reviewed
Jul 12, 2023
robusta_krr/main.py
Outdated
| selector: Optional[str] = typer.Option( | ||
| None, | ||
| "--selector", | ||
| help="Selector (label query) to filter on, supports '=', '==', and '!='.(e.g. -l key1=value1,key2=value2). Matching objects must satisfy all of the specified label constraints.", |
There was a problem hiding this comment.
The -l bit is confusing as it has different semantics in krr.
There was a problem hiding this comment.
Yeah, help is wrong - I removed -l
|
Otherwise LGTM, I verified it for my use case and it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added label selector to filter out what exact objects to scan, a proposed by @dohnto-s1
Added as
--selector, because-l(the same as in kubectl) is already occupiedWill close #62