Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes: respect --fileoutput in CSV and rename -f csv-export to -f csv #290

Merged
merged 9 commits into from
Jun 15, 2024

Conversation

aantn
Copy link
Contributor

@aantn aantn commented Jun 15, 2024

Motivation

We've had a number of bug reports over email about the csv export which doesn't respect --fileoutput.

This PR fixes that by changing the csv export so it respects --fileoutput. For any users who prefer the old behavior, I've added a --fileoutput-dynamic flag that they can use to keep the previous behavior.

Other Changes

I've also renamed the csv export so it is consistent with other exporter names. I've removed redundant code and made a tiny improvement to the table output in response to a common source of confusion w/ users.

Testing

I tested this PR manually by checking all the new flags and by checking behavior without any flags to verify that everything works as expected.

@aantn aantn requested a review from arikalon1 June 15, 2024 06:58
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

left one minor comment

robusta_krr/formatters/csv.py Outdated Show resolved Hide resolved
@aantn aantn merged commit 4d15999 into main Jun 15, 2024
2 checks passed
@aantn aantn deleted the minor-improvements-to-formatting-output branch June 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants