Add support for Azure Workload Identity #975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failed test is about slack, not related to my changes |
|
Thanks @EppO , will test that asap. |
EppO
force-pushed
the
azure-workload-identity
branch
3 times, most recently
from
a30f2f1 to
8a2d61e
Compare
EppO
force-pushed
the
azure-workload-identity
branch
from
8a2d61e to
b7b68cf
Compare
EppO
force-pushed
the
azure-workload-identity
branch
2 times, most recently
from
0e15195 to
085a820
Compare
EppO
force-pushed
the
azure-workload-identity
branch
from
085a820 to
ead0426
Compare
pavangudiwada
added
the
needs-review
|
Hi @EppO, I'm testing this PR and I have some issues with authentication. Is this PR still relevant? And how is it related to robusta-dev/prometrix#12? |
robusta-dev/prometrix#12 implements the Azure Workload Id authentication along with the rest of managed prometheus service authentications. My plan is too rework this PR as soon as robusta-dev/prometrix#12 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add annotations on Kubernetes Runner service and deployment to support Workload Identity