Merkeltree upstream #314
Open
Merkeltree upstream #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I upstreamed your changes to go-merkletree. I tried my best to verify that everything still worked the same, but I don't have an archive node, and the new multicaller setup takes too long to use Alchemy because the API timeout is 5 seconds, and at least getting the node addresses takes longer than that. A bit unfortunate.
I thought maybe you are still doing this kind of testing, so it would be easy for you to verify a previous interval. If you want me to test it, I guess I can ask to use someones archive node on the Discord.
I see no reason that it wouldn't work because there's really good test coverage in go-merkletree, but still, anything is possible and I don't want to break everything.