Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more SERP features #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chrisjoyce911
Copy link
Contributor

Google SERP has many different features, at the moment the Search() only returns the Organic results

Some of the other features that the SERP contains are

To keep backward compatibility it would be best to maintain the Search() return types.

As every remote call contains all the results for all of the SERP features, process leaves two options.

  1. Process the DOM and only return the selected feature
  2. Process the DOM and return all features found on the DOM
  3. Retrieve the DOM and have calls to feature functions process the DOM and return that features result

This patch has an option to maintain the current Search()

I have included for example only showing what option 2 or 3 could look like

Option 2 example line 313

Option 3 example line 320

This is not intended to mare at this stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant