Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the factors already mentioned #2485

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

jimcat8
Copy link
Contributor

@jimcat8 jimcat8 commented Nov 10, 2024

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)


* **Pre-current**: at a given time (before a system update, ...).
* **Periodic**: Daily, weekly, monthly, ...
* **aperiodic**: Backup within a specific time period before a major system update (usually in the early morning hours)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimcat8 While "periodic" and "aperiodic" are essentially words that mean the same thing, the most common term in backup parlance is "periodic." I suggest that you put the original "Periodic" back in. The descriptions you've added are fine. I might also add that this: "(usually in the early morning hours)" assumes that everyone's backup practices are this way. I'd delete that part of your added description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimcat8 I've fixed this so that the PR can be merged

Copy link

Test results for ff088c4:

Number of broken URLs: 6

URL,RESULT,FILENAME
 http://rocky.reloumirrors.net/9.4/extras/x86_64/os/repodata/7d78a729-8e9a-4066-96d4-ab8ed8f06ee8-FILELISTS.xml.gz,failed,books/web_services/053-load-balancer-proxies-squid.md
 http://miroir.univ-lorraine.fr/rocky/9.4/AppStream/x86_64/os/repodata/1af312c9-7139-43ed-8761-90ba3cd55461-UPDATEINFO.xml.gz,failed,books/web_services/053-load-balancer-proxies-squid.md
 http://www.example.org/foo.txt,failed,books/web_services/052-load-balancer-proxies-varnish.md
 http://0.0.0.0:61208/,failed,guides/network/glances_network_monitoring.md
 https://www.qyecst.cn,failed,guides/contribute/README.md
 https://rsnapshot.org/download.html,failed,guides/backup/rsnapshot_backup.md

@sspencerwire sspencerwire merged commit 9333e02 into rocky-linux:main Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants