Skip to content

Latest commit

 

History

History
62 lines (48 loc) · 5.09 KB

CONTRIBUTING.md

File metadata and controls

62 lines (48 loc) · 5.09 KB
Raw

Contributing

Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great.

Contributions to this project are released to the public under the MIT.

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

Submitting a pull request

  1. Fork and clone the repository
  2. Create a new branch: git checkout -b my-branch-name
  3. Make your changes, ensure that they include steps to install, validate post-install and update software report (please see How to add new tool for details).
  4. Test your changes by creating VHD and deploying a VM.
  5. Push to your fork and submit a pull request

Here are a few things you can do that will increase the likelihood of your pull request being accepted:

  • Follow the style guide for Powershell when writing Windows scripts. There is currently no set style for the Shell scripts that run Linux installs 🔜.
  • Include complete details of why this is needed in the PR description.
  • Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
  • Write good commit messages.
  • For new tools:
    • Make sure that the tool satisfies Software Guidelines.
    • Create an issue and get an approval from us to add this tool to the image before creating the pull request.

How to add new tool

General rules

  • For every new tool add validation scripts and update software report script to make sure that it is included to documentation
  • If the tool is available in other platforms (macOS, Windows, Linux), make sure you include it in as many as possible.
  • If installing a few versions of the tool, consider putting the list of versions in the corresponding toolset.json file. It will help other customers to configure their builds flexibly. See toolset-windows-2016.json as example.
  • Use consistent naming across all files
  • Validation scripts should be simple and shouldn't change image content

Windows

  • Add a script that will install the tool and put the script in the scripts/Installers folder.
    There are a bunch of helper functions that could simplify your code: Choco-Install, Install-Binary, Install-VsixExtension, Start-DownloadWithRetry, Test-IsWin16, Test-IsWin19 (find the full list of helpers in ImageHelpers.psm1).
  • Add a script that will validate the tool installation and put the script in the scripts/Tests folder.
    We use Pester v5 for validation scripts. If the tests for the tool are complex enough, create a separate *.Tests.ps1. Otherwise, use Tools.Tests.ps1 for simple tests.
    Add Invoke-PesterTests -TestFile <testFileName> [-TestName <describeName>] at the end of the installation script to make sure that your tests will be run.
  • Add changes to the software report generator images/win/scripts/SoftwareReport/SoftwareReport.Generator.ps1. The software report generator is used to generate an image's README file, e.g. Windows2019-Readme.md and uses MarkdownPS.

Ubuntu

  • Add script that will install and validate the tool and put the script in the scripts/installers folder. Use existing scripts such as github-cli.sh as a starting point.
    • Use helpers to simplify installation process.
    • Validation part should exit 1 if any issue with installation.
  • Add changes to the software report generator images/linux/scripts/SoftwareReport/SoftwareReport.Generator.ps1. The software report generator is used to generate an image's README file, e.g. Ubuntu1804-Readme.md and it uses MarkdownPS.

macOS

macOS source lives in this repository and available for everyone. However, macOS image-generation CI doesn't support external contributions yet so we are not able to accept pull-requests for now. We are in the process of preparing macOS CI to accept contributions. Until then, we appreciate your patience and ask you continue to make tool requests by filing issues.

Resources