Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenStruct from the project (solve warnings) #1169

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

arthurhess
Copy link
Contributor

@arthurhess arthurhess commented Nov 7, 2024

Description of the change

This pull request aims to solve one of the warnings we've been getting when loading the gem (#1165)

/usr/local/lib/ruby/3.3.0/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.

OpenStruct was introduced in the project back in 2017 to be used a test double.

I'm proposing replacing those OpenStruct instances with RSpec doubles.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@arthurhess
Copy link
Contributor Author

@waltjones Ready for review, and happy to make any adjustments as needed. 🙏 Thank you!

Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthurhess Thank you for the PR!

@waltjones waltjones merged commit 11f60a3 into rollbar:master Nov 7, 2024
25 checks passed
@arthurhess
Copy link
Contributor Author

Hi @waltjones! I'm wondering if you're planning on releasing this, of if it's too small of a change.

Thanks! 🙏

@ilkecan ilkecan mentioned this pull request Dec 18, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about logger and ostruct in Ruby v3.3.5
2 participants