feat: update react-app with latest romcal calendar & features #13
+475
−386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emagnier
commented
Oct 25, 2024
| @@ -5,7 +5,7 @@ | |||
| "type": "module", | |||
| "scripts": { | |||
| "build": "tsc && NODE_NO_WARNINGS=1 vite build", | |||
| "build:dev": "VITE_DAY_VARIANT=developer npm run build", | |||
| "build:dev": "NODE_OPTIONS='--max-old-space-size=8192' VITE_DAY_VARIANT=developer npm run build", | |||
There was a problem hiding this comment.
With more and more calendars and data, I had to increase the memory here, otherwise I couldn't build the site anymore.
emagnier
commented
Oct 25, 2024
| "@tanstack/react-query": "^5.56.2", | ||
| "classnames": "^2.5.1", | ||
| "date-fns": "^4.1.0", | ||
| "flatted": "^3.3.1", | ||
| "i18next": "^23.15.2", |
There was a problem hiding this comment.
This has been new since converting the Romcal codebase into a monorepo. I'm not sure if it's a bug or an improvement... Previously, i18next was bundled with Romcal's source code, but now it has to be added explicitly to use Romcal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the React app site, which also serves as the base for romcal.js.org.