Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

noDuplicateElseIf, no-dupe-else-if #3967

Open
Tracked by #3953
ematipico opened this issue Dec 6, 2022 · 8 comments
Open
Tracked by #3953

noDuplicateElseIf, no-dupe-else-if #3967

ematipico opened this issue Dec 6, 2022 · 8 comments
Labels
A-Linter Area: linter I-Difficult Implementation: requires deep knowledge of the tools and the problem. I-Normal Implementation: normal understanding of the tool and awareness

Comments

@ematipico
Copy link
Contributor

ematipico commented Dec 6, 2022 •
edited
Loading

https://eslint.org/docs/latest/rules/no-dupe-else-if
@ematipico ematipico mentioned this issue Dec 6, 2022
Open
30 tasks
@ematipico ematipico changed the title https://eslint.org/docs/latest/rules/no-dupe-else-if noDuplicateElseIf, no-dupe-else-if Dec 6, 2022
@ematipico ematipico added I-Normal Implementation: normal understanding of the tool and awareness I-Difficult Implementation: requires deep knowledge of the tools and the problem. labels Dec 6, 2022
@github-actions
Copy link

👋 @rome/staff please triage this issue by adding one of the following labels: S-Bug: confirmed, S-Planned , S-Wishlist or umbrella

@edvardchen
Copy link
Contributor

I can work on this

@github-actions github-actions bot removed the S-Stale label Dec 28, 2022
@Conaclos Conaclos added the A-Linter Area: linter label Feb 22, 2023
@Conaclos
Copy link
Contributor

Conaclos commented Mar 8, 2023 •
edited
Loading

@edvardchen Are you still interested in this rule?

@edvardchen
Copy link
Contributor

@Conaclos sorry, recently I have little time for open source projects. You can assign it to someone else.

@n-gude
Copy link

n-gude commented Jun 22, 2023

I would like to try my hand at this.
One question: Should the rule be implemented exactly like the one from ESLint, or should I include a case distinction that distinguishes between duplicated conditions and those excluded by previous conditions (see subrule regarding || and &&) and output two different messages?

@Conaclos
Copy link
Contributor

You are welcome :)

It could be nice to have two distinct messages for helping to understand why the rule reports this case.

@ematipico
Copy link
Contributor Author

@n-gude any updates?

@n-gude
Copy link

n-gude commented Jul 29, 2023

@ematipico Haven't had quite as much time the last few weeks, but I'm working on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Linter Area: linter I-Difficult Implementation: requires deep knowledge of the tools and the problem. I-Normal Implementation: normal understanding of the tool and awareness
Projects
ESlint recommended rules
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ematipico @edvardchen @Conaclos @n-gude