Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Commit

Permalink
Merge pull request #74 from ropensci/dev
Browse files Browse the repository at this point in the history
updated for CRAN
  • Loading branch information
bretsw authored Aug 19, 2022
2 parents 9420c09 + c38ac4d commit 14a9ee6
Show file tree
Hide file tree
Showing 12 changed files with 522 additions and 105 deletions.
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: tidytags
Title: Importing and Analyzing Twitter Data Collected with Twitter Archiving Google Sheets
Version: 1.0.0
Version: 1.0.1
License: MIT + file LICENSE
Authors@R: c(
person("K. Bret", "Staudt Willet", ,
Expand Down Expand Up @@ -36,8 +36,7 @@ Imports:
googlesheets4 (>= 1.0),
rlang (>= 1.0),
rtweet (>= 1.0),
stringr (>= 1.4),
tibble (>= 3.1)
stringr (>= 1.4)
Suggests:
beepr,
covr,
Expand All @@ -48,6 +47,7 @@ Suggests:
readr,
rmarkdown,
testthat,
tibble,
tidygraph,
urltools,
vcr (>= 1.0)
Expand Down
18 changes: 3 additions & 15 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,15 @@ tidytags development version

*

tidytags 1.0.1 (2022-08-06)
tidytags 1.0.1 (2022-08-18)
=========================

### BREAKING CHANGES

*

### NEW FEATURES

*

### BUG FIXES

*

### DOCUMENTATION FIXES

*
* Cleaned up documentation in preparation for CRAN submission.


tidytags 1.0 (2022-08-05)
tidytags 1.0.0 (2022-08-05)
=========================

### BREAKING CHANGES
Expand Down
18 changes: 12 additions & 6 deletions R/analyze-network.R
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@ create_edgelist <-
filtered_df_reply <-
dplyr::filter(filtered_df, .data$tweet_type == "reply")
receiver <- filtered_df_reply$in_reply_to_screen_name
el_reply <- dplyr::select(filtered_df_reply, .data$tweet_type, .data$sender)
el_reply <- dplyr::bind_cols(el_reply, receiver = receiver)
el_reply <-
dplyr::select(filtered_df_reply, .data$tweet_type, .data$sender)
el_reply <-
dplyr::bind_cols(el_reply, receiver = receiver)
}

if(nrow(dplyr::filter(filtered_df, .data$tweet_type == "retweet")) > 0) {
Expand All @@ -105,8 +107,10 @@ create_edgelist <-
receiver[i] <-
filtered_df_retweet$retweeted_status[[1]]$user$screen_name
}
el_retweet <- dplyr::select(filtered_df_retweet, .data$tweet_type, .data$sender)
el_retweet <- dplyr::bind_cols(el_retweet, receiver = receiver)
el_retweet <-
dplyr::select(filtered_df_retweet, .data$tweet_type, .data$sender)
el_retweet <-
dplyr::bind_cols(el_retweet, receiver = receiver)
}

if(nrow(dplyr::filter(filtered_df, .data$tweet_type == "quote")) > 0) {
Expand All @@ -117,8 +121,10 @@ create_edgelist <-
receiver[i] <-
filtered_df_quote$quoted_status[[1]]$user$screen_name
}
el_quote <- dplyr::select(filtered_df_quote, .data$tweet_type, .data$sender)
el_quote <- dplyr::bind_cols(el_quote, receiver = receiver)
el_quote <-
dplyr::select(filtered_df_quote, .data$tweet_type, .data$sender)
el_quote <-
dplyr::bind_cols(el_quote, receiver = receiver)
}

if(type == "all") {
Expand Down
236 changes: 209 additions & 27 deletions README.md

Large diffs are not rendered by default.

77 changes: 66 additions & 11 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,71 @@
# CRAN comments

## Test environments
## R CMD check results

- devtools::check() local MacOS Version 11.6 install, R 4.1.2
- GitHub Actions, macOS-latest, R release
- GitHub Actions, windows-latest, R release
- GitHub Actions, ubuntu-latest, R devel
- GitHub Actions, ubuntu-latest, R release
- GitHub Actions, ubuntu-latest, R 4.1
`devtools::check()` result:

## R CMD check results
**Test environment:** local MacOS Version 11.6 install, R 4.2.1

**0 errors ✔ | 0 warnings ✔ | 0 notes ✔ **

---

## GitHub Actions result:

**Test environments:**

- macOS-latest, R release
- windows-latest, R release
- ubuntu-latest, R devel
- ubuntu-latest, R release
- ubuntu-latest, R 4.2

**0 errors ✔ | 0 warnings ✔ | 0 notes ✔ **

---

`rhub::check_for_cran()` result:

**Test environment:** Windows Server 2022, R-release, 32/64 bit

**0 errors ✔ | 0 warnings ✔ | 0 notes ✔ **

---

`rhub::check_for_cran()` result:

**Test environment:** Windows Server 2022, R-devel, 64 bit

**0 errors ✔ | 0 warnings ✔ | 2 notes ✖ **

- checking CRAN incoming feasibility ... [18s]
- NOTE: Maintainer: 'K. Bret Staudt Willet <[email protected]>' New submission
- Explanation: This is my first time submitting **tidytags** to CRAN.

- checking for detritus in the temp directory ...
- NOTE: Found the following files/directories: 'lastMiKTeXException'
- Explanation: As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this could be due to a bug/crash in MiKTeX and can likely be ignored.

---

`rhub::check_for_cran()` result:

**Test environment:** Fedora Linux, R-devel, clang, gfortran

**0 errors ✔ | 0 warnings ✔ | 2 notes ✖ **

- checking CRAN incoming feasibility ... [4s/12s]
- NOTE: Maintainer: 'K. Bret Staudt Willet <[email protected]>' New submission
- Explanation: This is my first time submitting **tidytags** to CRAN.

- checking HTML version of manual ...
- NOTE: Skipping checking HTML validation: no command 'tidy' found
- Explanation: As noted in an [r-source check](https://github.com/wch/r-source/blob/trunk/src/library/tools/R/check.R), this seems like an issue related to macOS's old version of HTML Tidy and not related to the package being checked.

---

`rhub::check(platform = 'debian-gcc-devel')` result:

**Test environment:** Debian Linux, R-devel, GCC

N checking CRAN incoming feasibility (23.2s)
New submission
Maintainer: 'K. Bret Staudt Willet <[email protected]>'
**0 errors ✔ | 0 warnings ✔ | 0 notes ✔ **
35 changes: 19 additions & 16 deletions docs/articles/setup.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 14a9ee6

Please sign in to comment.