Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing any unsupported extensions #146

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

rkent
Copy link
Contributor

@rkent rkent commented Sep 1, 2024

Several packages add unsupported extensions in their conf.py files. Then when sphinx runs, it dies and we get no output.

This adds a check in the wrapping conf.py for the extensions that will be available when rosdoc2 is run in standard environments, and deletes (with a warning) any unsupported extension.

The PR also modifies a test to add all of these (plus one unsupported) to one of the test packages, to make sure that we both succeed with all standard extensions added, and that it does not die with an unsupported extension.

I'm trying to find PRs I can add which do apply cleanly to main (this is one), but really I need resolution of #139 to make progress. Most of my other patches cause conflicts which, if I attempt to resolve, will cause my rkent repo to diverge from ros-infrastructure in ways that will make it increasingly hard to maintain my fork.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks not crashing on these is much better behavior.

@tfoote tfoote merged commit 54dbcc5 into ros-infrastructure:main Sep 25, 2024
5 checks passed
@rkent rkent deleted the pr-check-extensions branch October 3, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants