Update of the manifest generation #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `pkg` argument is shadowed by a local variable without first being used.
Ebuild generation was not utilizing package conditions. Packages with multiple build types were causing hard failures during ebuild generation but it's possible that invalid ebuilds were being generated for other packages as well due to the lack of dependency conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the dockerfile ebuilds are built on and pushed it on docker hub. The current testing dockerfile is now under tomkimsour/ros_gentoo_base and the dockerfile can be found on ros-overlay repository once the pr I made gets accepted.
I also updated EAPI of the generated ebuild as well as the PYTHON_COMPAT.