Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dynamic_map_metadata service for requesting the map metadata. #46

Open
wants to merge 2 commits into
base: melodic-devel
Choose a base branch
from
Open

Added dynamic_map_metadata service for requesting the map metadata. #46

wants to merge 2 commits into from

Conversation

hiddewie
Copy link

Issue #45.

Adds a service for the map metadata: /dynamic_map_metadata. Requires adding a separate map metadata service, because it does not exist in nav_msgs.

I've added a new test for this service, just like for the normal /dynamic_map service. All tests pass.

k-okada
k-okada requested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiddewie thanks for contribution, could you rebase to melodic-devel ?

@hiddewie hiddewie changed the base branch from hydro-devel to melodic-devel October 5, 2020 18:04
@hiddewie
Copy link
Author

hiddewie commented Oct 5, 2020

@k-okada Thanks for the comment. 👍 I Rebased the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada requested changes

Assignees
No one assigned
Labels
reqeust to udpate PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddewie @k-okada