Skip to content

Releases: ros-tooling/action-ros-lint

0.1.4

07 Aug 22:49
Compare
Choose a tag to compare

Revert linelength argument

17 Mar 20:41
da8456d
Compare
Choose a tag to compare
Revert "Set linelength to 140 for lint action. (#246)" (#253)

This reverts commit 8f57e31edf2f376d34a8cb0bab48242933dd28b5,
but it updates the dist/index.js file.

Signed-off-by: Christophe Bedard <[email protected]>

0.1.2

05 Mar 19:23
8f57e31
Compare
Choose a tag to compare
  • Add support for custom linter arguments (#244)
  • Set cmake linelength to 140 for lint action. (#246)

0.1.1

12 Jan 21:52
Compare
Choose a tag to compare

Include minor fix "Run apt-get update before trying to install linter packages (#227)"

0.1.0

14 Dec 22:27
d6529ad
Compare
Choose a tag to compare

Bump to minor version release so that we can begin communicating API changes by version bumps

0.0.6: Bump npm dependencies

01 Apr 01:37
Compare
Choose a tag to compare

0.0.5: Remove extra quote in bash invocation (#15)

04 Dec 00:05
cd8ee0c
Compare
Choose a tag to compare
Currently, we use the following bash invocation to run the linter:

ament_<linter> $(colcon list --packages-select 'a b c')

The use of "colcon list" is to convert the list of package names into
packages paths that the linter expects.
I.e. we can run ament_copyright /path/to/pkg/a /path/to/pkg/b, but not
ament_copyright a b.

This fails because colcon list is looking for a single package called 'a b c'.
As there is no package called 'a b c'. What we want is instead selecting
package, "a", "b", and "c". This can be done by removing the single quotes
around the package list:

ament_<linter> $(colcon list --packages-select a b c)

Unfortunately, "colcon list" returns 0 (success), even if it fails to
match anything. Therefore, there is no easy way to detect this issue
with the current implementation. An alternative solution could be to
parse stderr, which is cumbersome, and brittle. For now, we chose to
only fix the issue, without introducing a test or a safety mechanism to
prevent regressions from happening.

Another problem is that ament_<linter> "/path/to/a /path/to/b" fails due
to the same issue, those extra quotes have also been removed.

Finally, this fixes the test. Until now, the test was not executed
properly, but it was never noticed because colcon fails silently
if no packages are matched. This requires the introduction of a new
parameter workspace-director allowing the linters to rely on a colcon
workspace located into a custom directory.

Signed-off-by: Thomas Moulard <[email protected]>

0.0.4: Add support for multiple packages (#14)

03 Dec 22:31
ee441c7
Compare
Choose a tag to compare

0.0.4: Add support for multiple packages (#14)

03 Dec 22:31
ee441c7
Compare
Choose a tag to compare

0.0.3: Add prettier configuration file (#8)

24 Oct 16:43
c7bbe14
Compare
Choose a tag to compare